fall back to network checkout when the mirror sticky disk stalls - #41
Open
Trent-TSE wants to merge 7 commits into
Open
fall back to network checkout when the mirror sticky disk stalls#41Trent-TSE wants to merge 7 commits into
Trent-TSE wants to merge 7 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ch on fallback Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…stall Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e5bccd. Configure here.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
On Aug 3 (and Jul 21/23), degraded Ceph reads on git-mirror sticky disks stalled
git fetch/git checkout(alternates object reads) until customers'timeout-minuteskilled the step — ~145 descriptinc jobs failed at exactly 300s, plus similar bursts for other orgs. Once the mirror was mounted there was no escape hatch: a slow disk meant a hard job failure instead of a slower network clone. This adds two "degrade, don't fail" layers:1. Read-health probe after mount (
blacksmith-cache.ts): right after mounting the sticky disk, read 8MB directly from the block device (dd iflag=direct, 10s deadline). On failure: unmount, release the disk (commitStickyDiskwithshouldCommit: false, via newreleaseStickyDisk()), and returnCacheInfo.readProbeFailed = true, which the caller treats likehydrationInProgress— standard network checkout, no mirror.2. Stall timeout on mirror-assisted fetch/checkout (
git-command-manager.ts,git-source-provider.ts): when the mirror is attached,git fetchandgit checkoutrun undertimeout -k 10 120(MIRROR_STALL_TIMEOUT_SECS). Exit code 124 raises the newGitStallTimeoutError, on which the provider:Mirror-assisted fetch skips the
retryHelperloop (single attempt) so a stall doesn't burn 3×120s before falling back. The post step is unchanged: refresh/GC already have their own timeouts and skip the commit on failure.dist/index.jsrebuilt vianpm run build.Testing
npx tsc --noEmit,npm run lint,npm run format-check,npm test(115 passed)Context: descriptinc read-stall incident Aug 3 (ClickHouse-verified: ~831s of read wait on /dev/vdb during a 5-min step, zero TCP retransmits; same signature on Jul 21 us-west and Jul 23 eu-west bursts).
Link to Devin session: https://app.devin.ai/sessions/63dfb9784da34f42a26241763bbb2d28
Requested by: @Trent-TSE
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.