Дубровин Алексей#16
Open
Griboedoff wants to merge 2 commits intourfu-2017:masterfrom
Open
Conversation
|
🍏 Пройден линтинг и базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
evgenymarkov
suggested changes
May 9, 2018
| // Ваши relations между моделями :) | ||
| Cart.belongsTo(User); | ||
| Cart.belongsToMany(Souvenir, { through: 'cart_souvenirs' }); | ||
| Review.belongsTo(Souvenir); |
There was a problem hiding this comment.
Souvenir.hasMany(Review) достаточно
| Cart.belongsToMany(Souvenir, { through: 'cart_souvenirs' }); | ||
| Review.belongsTo(Souvenir); | ||
| Review.belongsTo(User); | ||
| User.hasOne(Cart); |
| Review.belongsTo(Souvenir); | ||
| Review.belongsTo(User); | ||
| User.hasOne(Cart); | ||
| User.hasMany(Review); |
| } | ||
| }, { | ||
| timestamps: true | ||
| }); |
There was a problem hiding this comment.
Нет необходимости явным образом определять что либо в этой модели.
id, createdAt, updatedAt проставляются неявно Sequelize'ом.
userId также появится засчёт связи Cart.belongsTo(User).
| module.exports = (sequelize, DataTypes) => { | ||
| // Ваша модель страны | ||
| return sequelize.define('country', { | ||
| id: { |
| type: DataTypes.INTEGER, | ||
| allowNull: true | ||
| } | ||
| }, { |
There was a problem hiding this comment.
Всё также, много лишних явных объявлений
| module.exports = (sequelize, DataTypes) => { | ||
| // Ваша модель тэга | ||
| return sequelize.define('tag', { | ||
| id: { |
| module.exports = (sequelize, DataTypes) => { | ||
| // Ваша модель юзера | ||
| return sequelize.define('user', { | ||
| id: { |
| // подстрока substring. Поиск должен быть регистронезависимым. | ||
| return this.Souvenir.findAll({ | ||
| where: { | ||
| name: { [Sequelize.Op.contains]: substring } |
There was a problem hiding this comment.
ilike или iRegexp для регистронезависимого поиска
| souvenir.rating = ratings.reduce((a, b) => a + b, 0) / ratings.length; | ||
|
|
||
| await souvenir.save(); | ||
| } |
|
🍪 |
|
🍏 Пройден линтинг и базовые тесты |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.