unsloth: pin #166, and repin 27941 which is two rounds stale - #167
Closed
danielhanchen wants to merge 1 commit into
Closed
unsloth: pin #166, and repin 27941 which is two rounds stale#167danielhanchen wants to merge 1 commit into
danielhanchen wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
#166 makes sidecar discovery find MTP heads in a dedicated MTP/ folder, which is how both Qwen3.8-27B-GGUF and Qwen3.8-Flash-Next-GGUF publish them. Without it `--spec-type draft-mtp` finds nothing on either repo, and on the 27B the server refuses to start. The 27941 pin was still 6b2b85c. That branch has moved twice since, to 52bc9ff and then to 21c13c4, so the nightly has been building a commit that predates both the -kv-unified NaN collapse fix and the indexer ext.x/ext.y restore fix. Repin to the current head. Assisted-by: Claude
danielhanchen
force-pushed
the
unsloth/pin-166-and-repin-27941
branch
from
September 1, 2026 04:29
b42b45c to
1cad95e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pin changes.
Pin #166
#166 teaches sidecar discovery to look in a
dedicated
MTP/folder, which is how bothunsloth/Qwen3.8-27B-GGUFandunsloth/Qwen3.8-Flash-Next-GGUFpublish their draft heads.Without it,
--spec-type draft-mtpfinds nothing on either repo. On Flash-Next that is a silentmiss. On the 27B it is not silent: with no sidecar found the target is used as its own draft, and
the server refuses to start with
model doesn't contain MTP layers.Verified on the shipped
b10715-mix-86bd2d3prebuilt before the change and on a build of the branchafter it. Details and the full test matrix are in #166.
Repin 27941
The pin was still
6b2b85cf. That branch has moved twice since, to52bc9ff1and then to21c13c48, so the nightly has been building a commit that predates both of these:--kv-unifiedNaN collapse fix, where a sequence holding fewer thancompress_ratiocellsowned no block, its whole bias row was
-inf, and the softmax produced NaN that then reachedevery other sequence
ext.x/ext.yrestore fixRepinned to the current head,
21c13c48.