forked from ggml-org/llama.cpp
-
Notifications
You must be signed in to change notification settings - Fork 45
ci: ship test-backend-ops in the Vulkan and ROCm prebuilts #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielhanchen
wants to merge
2
commits into
master
Choose a base branch
from
ci/ship-test-backend-ops
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user extracts a Linux ROCm bundle and invokes
test-backend-opsnormally, the executable cannot locate its bundled shared libraries: this target links against sharedllama-common/llamalibraries and CMake gives build-tree binaries an absolute runner-build RPATH, while the laterSet RPATH for portable distributionstep only patches*.so*andllama-*(unsloth-prebuilt-rocm.yml:850-856). Becausetest-backend-opsmatches neither pattern, every Linux ROCm artifact ships the new diagnostic with a stale build-path RPATH unless the user manually setsLD_LIBRARY_PATH; include this executable in that patching loop or configure it with an$ORIGINRPATH.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, and it defeats the point of the PR: the loop globs
*.so*andllama-*,test-backend-opsmatches neither, so it would have shipped with the runner's build-tree RPATH and not started on a user's machine. A diagnostic nobody can launch is worse than no diagnostic, because it looks like it is there.Fixed by adding it to the patchelf loop rather than configuring a separate
$ORIGINRPATH, which keeps it consistent with how everything else in that bundle is treated.The Vulkan legs turn out to be unaffected: they configure with
CMAKE_BUILD_WITH_INSTALL_RPATH=ONandCMAKE_INSTALL_RPATH='$ORIGIN', so every binary from that tree already carries it, and Windows has no RPATH at all. So this was Linux ROCm only.