Repin ggml-org#25731 to the commit that merges onto b10369 - #100
Closed
danielhanchen wants to merge 2 commits into
Closed
Repin ggml-org#25731 to the commit that merges onto b10369#100danielhanchen wants to merge 2 commits into
danielhanchen wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly prebuild is currently broken.
ggml-org/llama.cpp#25731(TML Inkling) was pinned at0a9841fa63, and that commit stopped merging when the aged base moved tob10369, which landedmtmd: support pocket-tts (#26871). Both touchtools/mtmd/clip.cppandtools/mtmd/clip-model.h. The merge loop stops on the first conflict, so this did not just drop Inkling, it dropped the whole mix.Preflight run that caught it: https://github.com/unslothai/llama.cpp/actions/runs/31593981533
I resolved the conflicts on the PR branch itself, so the pin just moves to the new head.
The conflicts
tools/mtmd/clip.cpp, inhas_standard_layers. This is an and-chain of "the projector is not X". Inkling addsPROJECTOR_TYPE_INKLING, pocket-tts addsPROJECTOR_TYPE_POCKETTTS_GEN. Resolved to the union, so each side still excludes exactly what it meant to exclude. A model has oneproj_type, so adding a disjoint term cannot change the result for anything else.tools/mtmd/clip-model.h. Empty merge base for the hunk: both sides only append structs. Keptinkling_hmlp_layerfrom the PR andclip_seanetplusclip_flow_netfrom upstream.additive_merge.pyrefuses this one and is right to, since each side also touched the shared closing brace, so it cannot prove the hunk is a pure addition.The resolution adds no lines of its own. Checked by line multiset against both parents and the merge base: every line either side added is present, and nothing originates from neither.
Verification
Replayed the merge loop from
unsloth-prebuilt.ymlagainst the same aged base the preflight resolves, inpr-set.jsonorder:Built the resulting mix tree, not just the merge:
llama-server,llama-mtmd-cli,test-samplingat-DCMAKE_BUILD_TYPE=Release -DGGML_NATIVE=ON -DLLAMA_BUILD_TESTS=ON. No errors, no warnings.Ran the tests the PR ships, on the mix:
test-llama-archs,test-flash-attn-bias,test-flash-attn-generic-hashandtest-chatall pass.test-samplingpasses too, which covers #95.Loaded the real
unsloth/Inkling-Small-GGUFmmproj throughclip_initon the mix. Projectorinkling, vision and audio both up,n_mmproj_embd=4096, and 8 and 2 tensors rather than a standard layer stack, which is whathas_standard_layers == falseis meant to do. Then built the pre-merge PR head on its own and compared: loader behaviour is identical on the Inkling mmproj and on an ordinary Qwen3.6 mmproj, which still loads its full 334 tensor standard path.