Repository navigation
fix(demo): host the Apple sample template hero image permanently - #544
Merged
Merged
Conversation
The MacBook Pro hero in the demo's Apple sample template pointed at a temporary AI-generated image URL (_magic_images/). Those files are deleted 7 days after they are generated, so the hero stopped loading. Point it at the same image, uploaded as a regular asset that does not expire. Co-Authored-By: Claude Code (claude-opus-5-5 xhigh) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 2 2
Lines 78 78
Branches 20 20
=======================================
Hits 76 76
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MacBook Pro hero in the demo's Apple sample template (
demo/src/example/sample.json) pointed athttps://assets.unlayer.com/projects/167/_magic_images/de92eee8-….jpg. That's a temporary AI-generated image: those files are deleted 7 days after they're generated, so the hero is broken on https://react-email-editor-demo.netlify.app/.Change
The template now uses the same M5 MacBook Pro image, uploaded as a regular asset that doesn't expire:
https://assets.unlayer.com/projects/139/1792954848102-macbook-pro-m5-hero.jpgIt's 701×433, about the same width as the template's other images. One URL changes.
Validation
sample.jsonparses and loads in the builder with the hero rendering, including the M5 Pro and M5 Max chips.