Repository navigation
chore(api): Regenerate the build API plumbing - #14
Merged
Merged
Conversation
The build spec now takes a build without a Kraftfile, which builds the context's Dockerfile on the base-compat runtime, and reads the request's kraftfile and contexts back on the build. The generated models and the docs still presented the Kraftfile as required. Regenerate the build models from the prod-staging spec, and say in the client's docstrings and the README what a build without one is. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
danielvallance
approved these changes
Oct 21, 2026
danielvallance
left a comment
danielvallance
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-by: Daniel Vallance daniel@unikraft.com
Approved-by: Daniel Vallance daniel@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build spec now takes a build without a Kraftfile, which builds the context's Dockerfile on the base-compat runtime, and reads the request's kraftfile and contexts back on the build. The generated models and the docs still presented the Kraftfile as required.
Regenerate the build models from the prod-staging spec, and say in the client's docstrings and the README what a build without one is.