Repository navigation
feat(resources): Add the build client - #10
Merged
danielvallance merged 1 commit intoOct 20, 2026
Merged
danielvallance merged 1 commit into
danielvallance merged 1 commit into
Conversation
dragosgheorghioiu
marked this pull request as draft
October 20, 2026 13:17
dragosgheorghioiu
force-pushed
the
dragosg/tool-1672-generate-the-python-build-client-in-python-sdk
branch
from
October 20, 2026 13:19
35d6c66 to
1b81df7
Compare
The SDK had no client for the build API, so a Python caller built images through the CLI and could not follow a build's progress or read what it pushed. Generate the plumbing from build.yaml, skipping the progress stream the templates cannot return, and add ukc.builds on top: it follows the stream across cuts, skipping what it has seen, and takes its sources from constructors that carry only what was given. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
dragosgheorghioiu
force-pushed
the
dragosg/tool-1672-generate-the-python-build-client-in-python-sdk
branch
from
October 20, 2026 16:47
7d159c4 to
ce45a4a
Compare
nderjung
reviewed
Oct 20, 2026
Comment on lines
+59
to
+64
| | Code | Description | | ||
| |--------------------|-------------| | ||
| | `invalid` | `400`: the request is malformed, or a value in it is | ||
| not valid: the body is not JSON, a required field is missing, a source has | ||
| more than one of `session`, `git` and `url`, an image reference does not | ||
| parse, an inline Kraftfile does not parse or cannot be built, ... | |
Member
There was a problem hiding this comment.
lmao we should probs fix to not wrap MK tables in the generator
danielvallance
left a comment
danielvallance
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-by: Daniel Vallance daniel@unikraft.com
Approved-by: Daniel Vallance daniel@unikraft.com
danielvallance
self-requested a review
October 20, 2026 19:29
danielvallance
approved these changes
Oct 20, 2026
danielvallance
left a comment
danielvallance
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-by: Daniel Vallance daniel@unikraft.com
Approved-by: Daniel Vallance daniel@unikraft.com
danielvallance
deleted the
dragosg/tool-1672-generate-the-python-build-client-in-python-sdk
branch
October 20, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK had no client for the build API, so a Python caller could not follow a build's progress or read what it pushed.
Generate the plumbing from build.yaml, skipping the progress stream the templates cannot return, and add ukc.builds on top: it follows the stream across cuts, skipping what it has seen, and takes its sources from constructors that carry only what was given.