Repository navigation
Conversation
Vale joins the lines of a paragraph with spaces before it runs a token rule, so the old regex fired on every paragraph that already kept one sentence per line. A script rule walks the raw lines instead, and skips fenced code blocks. Signed-off-by: aabedraba <abdallah@unikraft.com>
aabedraba
temporarily deployed
to
pull-requests
November 3, 2026 18:47 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
@claude review |
The raw scope keeps the frontmatter, so a note text with two sentences in one YAML value tripped the rule. Signed-off-by: aabedraba <abdallah@unikraft.com>
aabedraba
temporarily deployed
to
pull-requests
November 3, 2026 19:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
these commits were merged in (#366) right ? |
Collaborator
Author
|
Correct @danielvallance |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unikraft.NoSentenceBreaksfires on every paragraph in the repo, because vale joins the lines of a paragraph with spaces before it matches, so. Aat a line break looks the same as. Ainside a line. That's why every PR gets a wall of "Only use one sentence per line" comments on perfectly fine lines (#366, #363, #358).This swaps it for a script rule on the raw text, which walks the lines itself and skips code fences. On the current pages it finds 517 lines that really have two sentences, and nothing inside a code block. I think vale-action only reports on added lines, so those 517 won't fail anyone's PR until they touch them.
Not TODO: