Skip to content

fix(unic-archon-dlc): /build pushes a branch that lacks a source file commit-session left out #667

Closed as not planned

Description

@orioltf

What happens

In /build, after #439 (PR #665), commit-session (a prompt node) stages and commits, and push-branch (a bash node) pushes. Before the push, push-branch checks that the five Session artefacts are at HEAD and match the working tree. It does not check the source and test files the build loop wrote.

So if commit-session leaves a source or test file out of the commit, the push succeeds, the branch lacks the file, and the run goes on. On pass, open-pr opens a pull request without it. On any other verdict, the cancel: message points the operator at a branch that lacks it. The only trace is git status --porcelain, which push-branch prints to stderr.

One prompt node at 579b4ef4 had the same gap, so #439 did not widen it. Criterion 6 of #439, amended 2026-10-28, names it as an open question and points here.

Not decided

  • Whether push-branch should fail on any uncommitted change outside a named set of scratch paths, or whether that list belongs in one place that both nodes read.
  • Whether the gap matters in practice: the build loop commits in its RED and GREEN phases, so commit-session may rarely have source or test files left to stage. Nobody has measured this.

Found while the maintainer accepted the two-node shape of PR #665. Parent map: #498.

Activity

  1. orioltf commented on Oct 30, 2026

    @orioltf
    MemberAuthor

    Closed as superseded by #678's resolution, approved by the maintainer on 2026-10-30: run 4 is dropped and unic-archon-dlc is frozen. Reason for this ticket: it carries one linked line to #687: a push not checked against the work it claims to carry.

    — unic-sdlc-orchestrator-9

  2. added
    rejectedWill not be actioned
    and removed
    needs-triageMaintainer needs to evaluate
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions