Skip to content

bug(unic-archon-dlc): a green /build that cannot open its pull request ends completed #666

Closed as not planned

Description

@orioltf

Problem

After #439, a /build run with a pass verdict reaches open-pr, which opens the pull request. open-pr is a prompt node. When it cannot open the pull request, it prints BLOCKED: … with the tool's error, but the node still ends green. A prompt node cannot fail by reporting.

  • In afk, build-pr-gate is skipped by its own when, and the run ends completed with no pull request.
  • In hitl, build-pr-gate asks a human to review a pull request that does not exist, and an approval ends the run completed.

Causes include a tracker contract that names a repository other than origin (a fork setup), a tracker tool or permission error, and a missing docs/agents/issue-tracker.md. The failure shows up only later, when /qa cancels at guard-no-open-pr (#652), away from its cause.

Found by review round 2 of PR #665, outside that ticket's scope. The class predates that pull request.

Acceptance criteria

  • A /build run whose open-pr opened no pull request does not end completed, in afk or in hitl.
  • The run's last message says that the verdict was pass, that no pull request was opened, why, and on which branch and commit the work is.
  • build-pr-gate never asks for a review of a pull request that does not exist.
  • docs/boxes/unic-dlc-build.md describes the case and its message.
  • A run that opens its pull request behaves as it does today.

Activity

  1. orioltf commented on Oct 28, 2026

    @orioltf
    MemberAuthor

    This was generated by AI during triage.

    Reproduced by reading unic-dlc-build.yaml at 231e09b0 on PR #665, not by a run. open-pr is a prompt node with no output_format that a later node reads, so its BLOCKED line changes no terminal status. A reviewer proposed an output_format with a pr_url field and a cancel: leaf after open-pr on an empty pr_url. That shape needs build-pr-gate to depend on the non-empty side, which is a design choice for the maintainer.

    Blocked by #439, which introduces the node shape this builds on. Left at needs-triage.

  2. orioltf commented on Oct 30, 2026

    @orioltf
    MemberAuthor

    Closed as superseded by #678's resolution, approved by the maintainer on 2026-10-30: run 4 is dropped and unic-archon-dlc is frozen. Reason for this ticket: it carries one linked line to #687: completed not derived from the pull request.

    — unic-sdlc-orchestrator-9

  3. added
    rejectedWill not be actioned
    and removed
    needs-triageMaintainer needs to evaluate
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions