Skip to content

bug(unic-archon-dlc): an unverified finding has no way out of the ledger #662

Closed as not planned

Description

@orioltf

Problem

#482 adds the verdict unverified to unic-dlc-pr-review. In reconcile, a prior unverified finding with no match is fixed or unverified again, never retired. So an unverified finding leaves the summary's unverified list and its count only when its file changes between two recorded heads. Two kinds of finding never get there:

  • A scoped finding, whose file is pull request, work item or repository. It has no path, so it is never fixed. It has no thread either, so the "a person closes it" of the ticket's decision 6 has nothing to act on.
  • An anchored unverified finding whose thread a person resolved after checking it by hand. prep reads no thread status into prior_verdict, so resolving the thread changes nothing in the ledger.

The reply on an unverified thread asks the author to resolve the thread if the finding is gone. Doing so has no effect on what the Box reports, and the unverified count grows over the life of a pull request.

Found by review round 1 of PR #661, which is out of that ticket's scope.

Acceptance criteria

  • The Box doc apps/claude-code/unic-archon-dlc/docs/boxes/unic-dlc-pr-review.md states how an unverified finding leaves the ledger, for an anchored finding and for a scoped one.
  • An anchored unverified finding whose thread a person resolved, and which the review does not report again, is no longer counted as unverified in the next iteration.
  • A scoped unverified finding has a way out that a person can take on the pull request, and the summary says what it is.
  • A resolved thread whose finding the review reports again is still reopened, as decision 7 of bug(unic-archon-dlc): reconcile marks a finding fixed when the next review omits it, and post resolves the thread #482 requires.

Activity

  1. orioltf commented on Oct 27, 2026

    @orioltf
    MemberAuthor

    This was generated by AI during triage.

    Reproduced by reading apps/claude-code/unic-archon-dlc/.archon/workflows/unic-dlc-pr-review.yaml at 299c3019 on PR #661, not by a run. reconcile's retired rule admits only a prior fixed, and the unverified rule takes a prior unverified with no match. prep sets prior_verdict from markers in the summary, and reads no thread status. A scoped finding owns no thread, so nothing on the pull request can close it.

    This depends on #482's verdicts and markers, so it is blocked by #482. It is left at needs-triage: the way out is a design question for the maintainer.

  2. orioltf commented on Oct 30, 2026

    @orioltf
    MemberAuthor

    Closed as superseded by #678's resolution, approved by the maintainer on 2026-10-30: run 4 is dropped and unic-archon-dlc is frozen. Reason for this ticket: it carries one linked line to #687: a claim with no way out of the ledger.

    — unic-sdlc-orchestrator-9

  3. added
    rejectedWill not be actioned
    and removed
    needs-triageMaintainer needs to evaluate
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions