Repository navigation
docs: define skills_version for runs of this repository - #260
Merged
Merged
Conversation
A telemetry record for a change to this repository is written after the change has landed, by which point the installed checkout has moved to the commit and tag the change introduced. The skill's own read then returns one state past the one the run's gates used. For such a run, define the field as the published state the change landed on: the describe of the landing commit's parent. A run whose change has not landed keeps the skill's definition.
The landing steps pull main only as part of tagging, which docs, chore and style merges skip, and a worktree cannot check out main at all. State the fetch that makes the squash-merge commit available instead of pointing at those steps.
gh pr view --json mergeCommit prints an object, which cannot stand in for the commit in the describe command. Add the jq filter that yields the SHA.
There was a problem hiding this comment.
🟢 Approval recommended
The documentation consistently resolves the post-merge telemetry ambiguity described in issue #258.
0 open findings
What changed in this PR
Defines deterministic skills_version telemetry for landed changes in this repository.
Changes:
- Derives the value from the landing commit’s parent.
- Preserves existing behavior for unlanded changes.
| File | Description |
|---|---|
CLAUDE.md |
Documents repository-specific telemetry version resolution. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/review-telemetry/SKILL.mdreads the record fieldskills_versionby runninggit describein the checkout the skills are installed from, and has the recording session attest that the result names the state the review gates ran under. For a run on this repository the record is written after the change has landed. When the skills are installed as symlinks into the main checkout, that checkout has by then moved to the commit and the tag the change itself introduced, so the read returns one state past the one intended.CLAUDE.mdnow defines the field for such a run as the published state the change landed on, which the history fixes.Closes #258
Changes
CLAUDE.mdhas a section,Telemetry record for a run of this repository, that definesskills_versionfor a run whose change has landed onmain: whatgit describe --tags --alwaysprints for the parent of the landing commit, recorded as returned. For such a run it replaces both the skill's command and its attestation.gh pr view <N> --json mergeCommit --jq .mergeCommit.oidand brought in withgit fetch origin, or the commit itself for a direct commit tomain.skills/review-telemetry/SKILL.mdis unchanged, so a run on any other repository is recorded as before.Verification
gh pr view 257 --json mergeCommit --jq .mergeCommit.oidprinted33563081759eef62acba4cfb2bb7dbb32063feab, andgit describe --tags --alwayson that commit's parent printed2026.10.11, the version published before fix(finding-triage,done-check,gh-body-audit,implement,review-pipeline): close a finding by its disposition #257 merged.pre-commit run --all-filespassed its three hooks: mdformat, ruff check, ruff format.Notes
skills_versionnow means one thing for a landed run of this repository and another for every other run, and a record carries no marker of which applied. The record schema stays 4.CLAUDE.mdbecause only this repository's runs are affected and that file is loaded exactly when an agent works here. A session that records one of this repository's runs without that file loaded falls back to the skill's command.