Skip to content

fix(authoritative-text-rules,bug-to-contract,code-review-gate,codex-contract-test-review,codex-plan-review,codex-review,copilot-review,diff-root,done-check,finding-to-audit,finding-triage,gate-miss-to-issue,gh-body-audit,gh-body-conventions,implement,quality-list,review-pipeline,stage-commit-push,todo-check): drop rationale that changes no executor action - #253

Merged
ultimatile merged 2 commits into
mainfrom
fix/51-redundant-why
Oct 11, 2026

Conversation

@ultimatile

@ultimatile ultimatile commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

The skill bodies a reviewed change passes through carried sentences that explain a rule without changing what the executing agent does: a second statement of a rule the same file already makes, a clause naming the benefit or consequence of an instruction, a note on what another skill owns. Each one is read on every run and is a second place for the rule to drift. This removes 67 of them from 19 SKILL.md files; no instruction is reworded.

Closes #252

Changes

  • Four rules are no longer repeated inside their own file. review-pipeline's Rules list does not restate the merge prohibition its merge-gate section gives, done-check's output section does not restate the dual-lane rendering rule its merge step gives, code-review-gate's telemetry note does not restate the waiver rule under Exhaustion, and finding-to-audit's closing list does not restate the routing of execution-dependent checks.
  • Trailing clauses that named an instruction's benefit ("to preserve formatting", "for reliable retrieval"), the consequence of not following it, or the mechanism that consumes its result are gone from stage-commit-push, diff-root, done-check, gh-body-audit, gh-body-conventions, finding-triage, copilot-review, codex-contract-test-review, codex-plan-review, todo-check, and gate-miss-to-issue.
  • quality-list and authoritative-text-rules say that runners apply their items by reference and read the index, without the sentences spelling out that a change therefore propagates.
  • review-pipeline and implement no longer tell an editor not to restate done-check's gate, and done-check no longer says where its own prohibition and its own exceptions are stated.
  • bug-to-contract and finding-to-audit open on their procedure: the "a single fix prevents one bug" line is gone from both.
  • codex-contract-test-review and codex-plan-review explain the blocks their prompt templates hold, and no longer list two blocks the templates leave out.
  • metadata.version is 2026.10.10.

The spans are quoted one by one in #252, each beside the sentence that still carries its action. Six more follow from that list: codex-plan-review, implement, and todo-check held the same clauses in the same words, and they went with their copies.

Verification

  • pre-commit run --files $(git diff --name-only origin/main...HEAD), which covers the 19 skill files and .claude-plugin/marketplace.json, reports the mdformat hook as Passed.
  • Every deletion was applied by exact-match replacement that checks how many times the span occurs before editing; all 67 matched their expected count.
  • A search of every Markdown, shell, Python, and TSV file under skills/, plus README.md and CLAUDE.md, finds none of the 67 removed spans.
  • The 16 sentences Track 2: redundant-why removal across the review-pipeline skills #252 lists as deliberately kept are each still present.

Notes

  • This does not remove every sentence that reads as rationale. A sentence stays when it is how the executor recognises that a case applies, when it is the reason a procedure exists and nothing else in the file states it, or when a neighbouring clause refers to it; Track 2: redundant-why removal across the review-pipeline skills #252 names the 16 that were considered and kept on those grounds.
  • The 16 SKILL.md files outside this set are not swept.

Plan-vs-actual delta

…ontract-test-review,codex-review,copilot-review,diff-root,done-check,finding-to-audit,finding-triage,gate-miss-to-issue,gh-body-audit,gh-body-conventions,quality-list,review-pipeline,stage-commit-push): drop rationale that changes no executor action

Remove 61 sentences and trailing clauses from the skill bodies the
review pipeline runs through. Each one restated a rule the same file
states elsewhere, described a consequence no decision depends on, or
noted what another skill owns; the instruction it sat beside is
unchanged and still carries the action.

Sentences that supply a recognition criterion, the reason a procedure
exists, or the referent of a neighbouring clause are kept.

Refs #252
…from sibling skills

Three skills held word-for-word copies of clauses the previous commit
removed from their siblings: the two "No <block>" bullets and the
stdin / retrieval tails in codex-plan-review, the note to editors in
implement, and the root and item-file tails in todo-check. Removing
one copy and keeping the other left the pairs disagreeing.

Refs #252

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The deletions preserve operative requirements, and no unresolved blocking issues remain.

0 open findings

What changed in this PR

Removes redundant rationale and repeated rules from 19 workflow skills, reducing instruction overhead while preserving executor actions, as requested in #252.

Changes:

  • Removes explanatory clauses and duplicate guidance.
  • Preserves operative instructions and workflow safeguards.
  • Bumps the plugin version to 2026.10.10.
File Description
skills/​todo-check/​SKILL.md Trims prompt-composition rationale.
skills/​stage-commit-push/​SKILL.md Removes routing and formatting explanations.
skills/​review-pipeline/​SKILL.md Removes repeated gates and explanatory clauses.
skills/​quality-list/​SKILL.md Trims propagation and lane explanations.
skills/​implement/​SKILL.md Removes redundant gate-maintenance guidance.
skills/​gh-body-conventions/​SKILL.md Trims rendering and evidence-check rationale.
skills/​gh-body-audit/​SKILL.md Removes audit-context explanations.
skills/​gate-miss-to-issue/​SKILL.md Trims proposal-ownership commentary.
skills/​finding-triage/​SKILL.md Removes redundant disposition explanations.
skills/​finding-to-audit/​SKILL.md Removes repeated promotion principles.
skills/​done-check/​SKILL.md Trims audit rationale and repeated output rules.
skills/​diff-root/​SKILL.md Removes explanations behind retained root rules.
skills/​copilot-review/​SKILL.md Trims script-flow explanations.
skills/​codex-review/​SKILL.md Removes reviewer-context rationale.
skills/​codex-plan-review/​SKILL.md Trims template and command rationale.
skills/​codex-contract-test-review/​SKILL.md Trims template and command rationale.
skills/​code-review-gate/​SKILL.md Removes repeated waiver guidance.
skills/​bug-to-contract/​SKILL.md Removes repeated contract-test rationale.
skills/​authoritative-text-rules/​SKILL.md Trims propagation and scope explanations.
.claude-plugin/​marketplace.json Updates version to 2026.10.10.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track 2: redundant-why removal across the review-pipeline skills

2 participants