Repository navigation
fix(authoritative-text-rules,bug-to-contract,code-review-gate,codex-contract-test-review,codex-plan-review,codex-review,copilot-review,diff-root,done-check,finding-to-audit,finding-triage,gate-miss-to-issue,gh-body-audit,gh-body-conventions,implement,quality-list,review-pipeline,stage-commit-push,todo-check): drop rationale that changes no executor action - #253
Merged
Merged
Conversation
…ontract-test-review,codex-review,copilot-review,diff-root,done-check,finding-to-audit,finding-triage,gate-miss-to-issue,gh-body-audit,gh-body-conventions,quality-list,review-pipeline,stage-commit-push): drop rationale that changes no executor action Remove 61 sentences and trailing clauses from the skill bodies the review pipeline runs through. Each one restated a rule the same file states elsewhere, described a consequence no decision depends on, or noted what another skill owns; the instruction it sat beside is unchanged and still carries the action. Sentences that supply a recognition criterion, the reason a procedure exists, or the referent of a neighbouring clause are kept. Refs #252
…from sibling skills Three skills held word-for-word copies of clauses the previous commit removed from their siblings: the two "No <block>" bullets and the stdin / retrieval tails in codex-plan-review, the note to editors in implement, and the root and item-file tails in todo-check. Removing one copy and keeping the other left the pairs disagreeing. Refs #252
There was a problem hiding this comment.
🟢 Approval recommended
The deletions preserve operative requirements, and no unresolved blocking issues remain.
0 open findings
What changed in this PR
Removes redundant rationale and repeated rules from 19 workflow skills, reducing instruction overhead while preserving executor actions, as requested in #252.
Changes:
- Removes explanatory clauses and duplicate guidance.
- Preserves operative instructions and workflow safeguards.
- Bumps the plugin version to
2026.10.10.
| File | Description |
|---|---|
| skills/todo-check/SKILL.md | Trims prompt-composition rationale. |
| skills/stage-commit-push/SKILL.md | Removes routing and formatting explanations. |
| skills/review-pipeline/SKILL.md | Removes repeated gates and explanatory clauses. |
| skills/quality-list/SKILL.md | Trims propagation and lane explanations. |
| skills/implement/SKILL.md | Removes redundant gate-maintenance guidance. |
| skills/gh-body-conventions/SKILL.md | Trims rendering and evidence-check rationale. |
| skills/gh-body-audit/SKILL.md | Removes audit-context explanations. |
| skills/gate-miss-to-issue/SKILL.md | Trims proposal-ownership commentary. |
| skills/finding-triage/SKILL.md | Removes redundant disposition explanations. |
| skills/finding-to-audit/SKILL.md | Removes repeated promotion principles. |
| skills/done-check/SKILL.md | Trims audit rationale and repeated output rules. |
| skills/diff-root/SKILL.md | Removes explanations behind retained root rules. |
| skills/copilot-review/SKILL.md | Trims script-flow explanations. |
| skills/codex-review/SKILL.md | Removes reviewer-context rationale. |
| skills/codex-plan-review/SKILL.md | Trims template and command rationale. |
| skills/codex-contract-test-review/SKILL.md | Trims template and command rationale. |
| skills/code-review-gate/SKILL.md | Removes repeated waiver guidance. |
| skills/bug-to-contract/SKILL.md | Removes repeated contract-test rationale. |
| skills/authoritative-text-rules/SKILL.md | Trims propagation and scope explanations. |
| .claude-plugin/marketplace.json | Updates version to 2026.10.10. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill bodies a reviewed change passes through carried sentences that explain a rule without changing what the executing agent does: a second statement of a rule the same file already makes, a clause naming the benefit or consequence of an instruction, a note on what another skill owns. Each one is read on every run and is a second place for the rule to drift. This removes 67 of them from 19
SKILL.mdfiles; no instruction is reworded.Closes #252
Changes
review-pipeline's Rules list does not restate the merge prohibition its merge-gate section gives,done-check's output section does not restate the dual-lane rendering rule its merge step gives,code-review-gate's telemetry note does not restate the waiver rule under Exhaustion, andfinding-to-audit's closing list does not restate the routing of execution-dependent checks.stage-commit-push,diff-root,done-check,gh-body-audit,gh-body-conventions,finding-triage,copilot-review,codex-contract-test-review,codex-plan-review,todo-check, andgate-miss-to-issue.quality-listandauthoritative-text-rulessay that runners apply their items by reference and read the index, without the sentences spelling out that a change therefore propagates.review-pipelineandimplementno longer tell an editor not to restatedone-check's gate, anddone-checkno longer says where its own prohibition and its own exceptions are stated.bug-to-contractandfinding-to-auditopen on their procedure: the "a single fix prevents one bug" line is gone from both.codex-contract-test-reviewandcodex-plan-reviewexplain the blocks their prompt templates hold, and no longer list two blocks the templates leave out.metadata.versionis2026.10.10.The spans are quoted one by one in #252, each beside the sentence that still carries its action. Six more follow from that list:
codex-plan-review,implement, andtodo-checkheld the same clauses in the same words, and they went with their copies.Verification
pre-commit run --files $(git diff --name-only origin/main...HEAD), which covers the 19 skill files and.claude-plugin/marketplace.json, reports themdformathook as Passed.skills/, plusREADME.mdandCLAUDE.md, finds none of the 67 removed spans.Notes
SKILL.mdfiles outside this set are not swept.Plan-vs-actual delta
codex-plan-review,implement, andtodo-check. Track 2: redundant-why removal across the review-pipeline skills #252 deferred four spans there as copies of deleted text. A review of the branch reported thatcodex-contract-test-reviewhad lost clausescodex-plan-reviewstill carried word for word, leaving the two skills disagreeing, so the copies were removed in this change instead of later. Two of the six are not among the four Track 2: redundant-why removal across the review-pipeline skills #252 names: the "to prevent stdin hanging" tail incodex-plan-reviewand the "the subagent reads the item files itself" tail intodo-check, each the same clause as one deleted from its sibling.SKILL.mdfiles stay unswept, down from the 18 Track 2: redundant-why removal across the review-pipeline skills #252 sets aside.