Skip to content

fix(todo-check): remove the per-item preflight framing section - #249

Merged
ultimatile merged 1 commit into
mainfrom
fix/232-todo-check-preflight-framing
Oct 4, 2026
Merged

ultimatile merged 1 commit into
mainfrom
fix/232-todo-check-preflight-framing

Conversation

@ultimatile

Copy link
Copy Markdown
Owner

Summary

skills/todo-check/SKILL.md carried a ## Preflight framing per item (quick reference) section: ten one-line phrasings, one per contextual-lane quality-list item, each wording the item as something to do before implementation. No step of the procedure read the section, and the section said of itself that it decides nothing about whether an item applies. This removes it.

Closes #232

Changes

  • skills/todo-check/SKILL.md has no per-item preflight phrasings. ## Output format follows the procedure's last step directly, and a contextual row's setup action is worded from the item body under the procedure's instruction to record the setup action to do now.
  • metadata.version in .claude-plugin/marketplace.json is 2026.10.7.

Impact

implement, which invokes todo-check, reads the △ active rows of the preflight table. The table's shape, its statuses, and the steps that build it are unchanged.

Eight of the ten phrasings named an action the item body already states. Two carried an instruction the item body lacks, and neither is moved elsewhere:

  • test-execution: capture the pre-existing failure baseline before any edit. The item body only says what to do if a baseline exists. skills/implement/SKILL.md and skills/research/SKILL.md each tell their own executor to run the existing tests before any change and record the failures, so a todo-check run reached through implement keeps the instruction. A todo-check run started on its own no longer has it in words.
  • invariant-derivation: list the derived condition in the plan. The item body says to derive the condition before committing and says nothing about the plan. No step in skills/ reads a derived condition out of a plan.

Verification

  • rg -n -i "quick reference|preflight framing" skills/todo-check/SKILL.md returns no match.
  • A fresh-context agent ran the quality-list part of the procedure's contextual step on two planned changes — a Rust bug fix that follows a research plan, and a Python feature with no plan — from a copy of the file with the section removed, without access to the original file or to git history. cmp reports that copy identical to the committed file. Every active row it produced recorded the action the removed phrasing named, except that the invariant-derivation row did not say to list the condition in the plan. The agent reported that it inferred the before-implementation form for six of the items from the procedure's wording and example rows. This is one run of one model on two changes.
  • The mdformat pre-commit hook reported Passed on the commit.

Notes

The opening paragraph of skills/quality-list/SKILL.md says a runner may carry a compressed mnemonic of an item in a quick reference. It is a permission and stays true with no such section in todo-check, so it is not edited here.

No step read the section: the procedure builds each contextual row from
the item body, and the caller takes only the active rows of the table.

Eight of its ten bullets restated what the item body already says. The
other two carried an instruction the body lacks. Capturing a failure
baseline before editing stays with the implement and research skills,
which state it themselves. Listing a derived invariant in the plan had
no step that read it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The scoped removal preserves the consumer contract, explicitly documents the standalone behavior change, and leaves no blocking findings.

Review effort: Balanced
Findings: None

What changed in this PR

Removes todo-check’s per-item preflight reference as proposed in #232, leaving setup actions derived from authoritative item bodies.

Changes:

  • Deletes the mnemonic section without changing the procedure or output table.
  • Bumps the plugin version to 2026.10.7.
File Description
skills/​todo-check/​SKILL.md Removes the per-item preflight reference.
.claude-plugin/​marketplace.json Updates the release version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ultimatile
ultimatile merged commit 1194a9c into main Oct 4, 2026
1 check passed
@ultimatile
ultimatile deleted the fix/232-todo-check-preflight-framing branch October 4, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

todo-check: Preflight framing per item section has no independent consumer

2 participants