Repository navigation
fix(todo-check): remove the per-item preflight framing section - #249
Merged
Merged
Conversation
No step read the section: the procedure builds each contextual row from the item body, and the caller takes only the active rows of the table. Eight of its ten bullets restated what the item body already says. The other two carried an instruction the body lacks. Capturing a failure baseline before editing stays with the implement and research skills, which state it themselves. Listing a derived invariant in the plan had no step that read it.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped removal preserves the consumer contract, explicitly documents the standalone behavior change, and leaves no blocking findings.
Review effort: Balanced
Findings: None
What changed in this PR
Removes todo-check’s per-item preflight reference as proposed in #232, leaving setup actions derived from authoritative item bodies.
Changes:
- Deletes the mnemonic section without changing the procedure or output table.
- Bumps the plugin version to
2026.10.7.
| File | Description |
|---|---|
skills/todo-check/SKILL.md |
Removes the per-item preflight reference. |
.claude-plugin/marketplace.json |
Updates the release version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/todo-check/SKILL.mdcarried a## Preflight framing per item (quick reference)section: ten one-line phrasings, one per contextual-lanequality-listitem, each wording the item as something to do before implementation. No step of the procedure read the section, and the section said of itself that it decides nothing about whether an item applies. This removes it.Closes #232
Changes
skills/todo-check/SKILL.mdhas no per-item preflight phrasings.## Output formatfollows the procedure's last step directly, and a contextual row's setup action is worded from the item body under the procedure's instruction to record the setup action to do now.metadata.versionin.claude-plugin/marketplace.jsonis2026.10.7.Impact
implement, which invokestodo-check, reads the△ activerows of the preflight table. The table's shape, its statuses, and the steps that build it are unchanged.Eight of the ten phrasings named an action the item body already states. Two carried an instruction the item body lacks, and neither is moved elsewhere:
test-execution: capture the pre-existing failure baseline before any edit. The item body only says what to do if a baseline exists.skills/implement/SKILL.mdandskills/research/SKILL.mdeach tell their own executor to run the existing tests before any change and record the failures, so atodo-checkrun reached throughimplementkeeps the instruction. Atodo-checkrun started on its own no longer has it in words.invariant-derivation: list the derived condition in the plan. The item body says to derive the condition before committing and says nothing about the plan. No step inskills/reads a derived condition out of a plan.Verification
rg -n -i "quick reference|preflight framing" skills/todo-check/SKILL.mdreturns no match.quality-listpart of the procedure's contextual step on two planned changes — a Rust bug fix that follows a research plan, and a Python feature with no plan — from a copy of the file with the section removed, without access to the original file or to git history.cmpreports that copy identical to the committed file. Every active row it produced recorded the action the removed phrasing named, except that theinvariant-derivationrow did not say to list the condition in the plan. The agent reported that it inferred the before-implementation form for six of the items from the procedure's wording and example rows. This is one run of one model on two changes.mdformatpre-commit hook reportedPassedon the commit.Notes
The opening paragraph of
skills/quality-list/SKILL.mdsays a runner may carry a compressed mnemonic of an item in a quick reference. It is a permission and stays true with no such section intodo-check, so it is not edited here.