Skip to content

varyrun stop IN.DAT being created#4206

Open
clmould wants to merge 1 commit intomainfrom
4204-varyrun-file-creation
Open

varyrun stop IN.DAT being created#4206
clmould wants to merge 1 commit intomainfrom
4204-varyrun-file-creation

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 27, 2026

Description

Closes #4204
Stops creating IN.DAT, MFILE.DAT and OUT.DAT in VaryRun runs (so now only makes the 0_, 1_ etc), update the __next__ method so no files are created once the max iterations are reached (as before if it reached max iterations it would create the next IN.DAT then error saying it can't find the associated MFILE), add messages to make clear if that iteration's file converged or not, update docs and varyrun example

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Apr 27, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.08%. Comparing base (b9e97d7) to head (976c7e5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/vary_run/config.py 25.58% 32 Missing ⚠️
process/core/io/vary_run/tools.py 62.50% 3 Missing ⚠️
process/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
- Coverage   52.10%   52.08%   -0.02%     
==========================================
  Files         148      148              
  Lines       30389    30414      +25     
==========================================
+ Hits        15835    15842       +7     
- Misses      14554    14572      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review April 27, 2026 18:03
@clmould clmould requested a review from a team as a code owner April 27, 2026 18:03
@clmould clmould force-pushed the 4204-varyrun-file-creation branch from 6490879 to d455a45 Compare April 27, 2026 18:14
…next__method so no more files are created once max iterations reached, update docs and varyrun example
@clmould clmould force-pushed the 4204-varyrun-file-creation branch from d455a45 to 976c7e5 Compare April 28, 2026 10:03
@clmould clmould changed the title varyrun stop IN.DAT being created and being default varyrun stop IN.DAT being created May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaryRun file creation

4 participants