Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
- Coverage 52.10% 52.08% -0.02%
==========================================
Files 148 148
Lines 30389 30414 +25
==========================================
+ Hits 15835 15842 +7
- Misses 14554 14572 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6490879 to
d455a45
Compare
…next__method so no more files are created once max iterations reached, update docs and varyrun example
d455a45 to
976c7e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4204
Stops creating IN.DAT, MFILE.DAT and OUT.DAT in VaryRun runs (so now only makes the 0_, 1_ etc), update the
__next__method so no files are created once the max iterations are reached (as before if it reached max iterations it would create the next IN.DAT then error saying it can't find the associated MFILE), add messages to make clear if that iteration's file converged or not, update docs and varyrun exampleChecklist
I confirm that I have completed the following checks: