chore: create the tag together with draft releases and remove duplicate 3.1.1 changelog sections - #44
Merged
Merged
Conversation
…te 3.1.1 changelog sections With "draft": true release-please created the v3.1.1 release without a tag. In the same run it then could not find the release it had just created, fell back to the full commit history and opened another 3.1.1 release PR, which the workflow auto-merged. That repeated for #42 and #43 until the run was cancelled. "force-tag-creation" makes release-please create the tag at the same time as the draft release, which is the documented fix for exactly this case. The two changelog sections produced by the repeated PRs are removed; the remaining 3.1.1 section is the one that matches the published release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
After #40 enabled
"draft": true, the release-please run that merged #41 created the v3.1.1 draft release and then, in the same run, could not find it: a draft has no tag, and release-please's release lookup does not see drafts. It treated the repository as unreleased, rebuilt the changelog from the whole history, hit theRelease-As: 3.1.1footer again and opened another 3.1.1 release PR. The workflow's auto-merge merged it, which repeated the cycle (#42, #43) until the run was cancelled.The first v3.1.1 (from #41, commit 9baae9a) is fine: it was published with
reminders.tar.gzattached and the homebrew formula is at 3.1.1. #42 and #43 only produced two untagged drafts, both named v3.1.1, which must be deleted manually.Fix
release-please-config.json:"force-tag-creation": true. release-please then creates the tag together with the draft release, so its tag fallback finds the release immediately. This is the documented fix for exactly this situation (see theforce-tag-creationcomment in release-please's manifest docs).CHANGELOG.md: removed the twov3.1.1...v3.1.1sections written by chore(main): release 3.1.1 #42 and chore(main): release 3.1.1 #43. The remaining 3.1.1 section is the one that matches the published release.CLAUDE.md: documents whyforce-tag-creationmust stay enabled withdraft.No release is triggered by this PR: the only commits since v3.1.1 are release commits and this chore.