Fix minor issue in sharelink backend and enable matching regression tests - #620
Open
jonasbardino wants to merge 29 commits into
Open
Conversation
…nd `main` functions for consistent lazy `environ` and `initialize_main_variables` set up without clunky `_main` wrappers. This should make it easier to achieve a standardized runtime environment in all interfaces, and allow us to considerably simplify the unit tests relying on more direct access to tweaking the environment and calls. Extended `environ` passing to `validate_input` for symmetry with `validate_input_and_cert`. Made argument passing from the latter use explicit keywords for clarity, too. Applied various linting suggestions from `ruff`.
Expose `path_info` in `create_http_environ` and rename previously "private" `_only_output_objects` to "public" `filter_output_objects`.
…s in the `cat.py` and `datatransfer.py` functionality backends to significantly simplify the clunky `main` + `_main` wrapping introduced for their unit tests. We can proceed with all the other backend functions after adjusting those unit tests accordingly.
… shared helpers from wsgisupp. Apply various updates to current unit testing support helpers. Tightened a few of the output_object checks to be more thorough about all entries. Applied make format and lint with some fixes for consistency.
…d inject it in `initialize_main_variables` calls there to let individual backends override options like `op_header` easily. Swapped the order of `environ` and `init_main_res`, so that `init_kw` sticks with `init_main_res` both in `main` and `lazy_init_backend`. Moved the dynamic `op_menu` logic into `initialize_main_variables` so that backends can just pass 'AUTO' if menu should only be shown if page was accessed with login (i.e. `client_id` value is set).
…riables in order to really let unit tests inherit the init_kwargs from main function e.g. in the docs.py test suite. Extended docs.py tests to cover more anonymous and authenticated use and in particular exercise the previsouly mentioned inheritance logic.
NOTE: identified two bugs in the backend while testing. So tests are left disabled but should be fixed separately with re-enabling the tests.
…responding minor bugs in the backend.
Most are disabled for now, however, because we hit a similar backend issue as for vgridworkflows where the title entry lacks the expected style and script sub-dicts when called from unit tests.
…uested but disabled like in other backends. Disabled corresponding failing tests until until those issues are fixed.
configuration across the functionality backend unit tests for consistency. Temporarily disabled the tests that started hitting the same script init issue we will fix in #615.
Most remain disabled until we #615 lands.
optional args instead of duplicating that effort (half-heartedly). Update tests to fit this consistent init with all `output_object` entries and re-enable all the tests that previously needed additional init tweaking. This is much cleaner and effectively renders the stand-alone extension branch fix/possibly-missing-title-entry-style-and-script-sub-dicts-and-empty-dict-default-arg-values obsolete.
Skip disabled test until backend is fixed to properly report error.
Re-enable corresponding unit test.
Martin-Rehr
approved these changes
Jul 29, 2026
Martin-Rehr
left a comment
Martin-Rehr
left a comment
Contributor
There was a problem hiding this comment.
Approved commit f02da99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a minor issue in the
sharelinkbackend identified during #612 development and enable the corresponding regression test prepared there. Namely that it does not check if the feature is actually enabled in configuration.IMPORTANT: please note that this PR works on top of #612 so it's only really the last small commit (f02da99). It's best to merge #612 first and rebase here for a minimal final merge.