xmlrpc client and server updates to make examples functional again by jonasbardino · Pull Request #595 · ucphhpc/migrid-sync

jonasbardino · 2026-07-15T12:59:58Z

Sync xmlrpc examples to use single shared setup from original example. Update to current xmlrpc API there.

Address some backend stub import issues (#594) when attempting to run the xmlrpc client examples.

…. Update to current xmlrpc API there.

``` Error 200:SYSTEM_ERROR DEBUG: [{'object_type': 'error_text', 'text': "Could not import module! shared.functionality.X: No module named 'shared'"}] ``` errors on attempted use.

…dling.

…sting with jsonrpc. Reinsert recently pruned parse_qs helper in xmlrpcbackup example.

…n the general xmlrpc client example. Add text-mode cat for symmetry with binary. Show the actual error from jobstatus for sites where jobs are disabled.

…eported in github actions. Bump at-job date to far future.

…rpcX examples relying on the shared connection init from xmlrpcsslclient.

…d enable reuse in the `xmlrpc.client.ServerProxy` calls.

…d enable reuse in the `xmlrpc.client.ServerProxy` calls like we do in #595 now.

Martin-Rehr

Approved with inline and final comments:

Should 'Error calling function' return an output object ?

migrid-sync/mig/shared/rpcfunctions.py

Line 129 in cff9685

return ('Error calling function: %s' % err, returnvalues.ERROR)
force_utf8_rec is now an unused import ?

* Change the `main` function calling error to use and return `output_object`. * Drop unused `force_utf8_rec` helper function along with a few bare `except` lint fixes.

jonasbardino · 2026-07-29T15:17:08Z

Approved with inline and final comments:

1. Should 'Error calling function' return an output object ?
   https://github.com/ucphhpc/migrid-sync/blob/cff96851fb06672776de24d8c503918f8aa7f3d0/mig/shared/rpcfunctions.py#L129

2. force_utf8_rec is now an unused import ?

1: yes, good catch. Fixed.
2: yes. Applied lint fixes about this one and a few bare excepts.

…`cacert` conf value with more care. Added a docstring line about it, too.

jonasbardino · 2026-07-30T06:56:12Z

There is still some python2 cruft e.g. in the imports to address remaining make lint import warnings plus the shared conf tuning and the possibly clean up/removal of unsupported functions highlighted in comments by @Martin-Rehr . Yet, first priority and target for this PR is to get the existing code and examples functional again, so I'll add the follow-up tag and leave further improvements for anyone with time.

#595: add more robust `cacert` conf handling and add missing retval unpacking.

@Martin-Rehr

…API (#596) * Migrate jsonrpclib to maintained fork and sync iclient and server interfaces to current API and reuse more from xmlrpcX example scripts. * Pull in fixes and polish from #595 xmlrpc client. * Pull in the rpcfunctions.py fixes from #595 also needed here. * Drop the explicit jsonrpc protocol cap and let it use protocol 2.0 since it also just works now. * Drop ancient python 2.6 compatibility. * Refactor `SafeCertTransport` to handle `ssl_ctx` init consistently and enable reuse in the `xmlrpc.client.ServerProxy` calls like we do in #595 now. * Address a few review feedback suggestions (thanks @Martin-Rehr) like in #595: add more robust `cacert` conf handling and add missing retval unpacking.

jonasbardino added 2 commits July 15, 2026 14:40

Sync xmlrpc examples to use single shared setup from original example…

a62213b

…. Update to current xmlrpc API there.

Fix absolute import location of RPC stub helpers to avoid the current

9c2c9e7

``` Error 200:SYSTEM_ERROR DEBUG: [{'object_type': 'error_text', 'text': "Could not import module! shared.functionality.X: No module named 'shared'"}] ``` errors on attempted use.

jonasbardino self-assigned this Jul 15, 2026

jonasbardino added bug Something isn't working enhancement New feature or request labels Jul 15, 2026

jonasbardino linked an issue Jul 15, 2026 that may be closed by this pull request

The mig/user/xmlrpcX.py examples fail with import errors when using stub functions #594

Closed

jonasbardino mentioned this pull request Jul 15, 2026

Migrate jsonrpclib to maintained fork and sync interfaces to current API #596

Merged

jonasbardino added 4 commits July 15, 2026 15:47

Sync wsgi stub into rpc version to eliminate exec and converge on han…

390fd51

…dling.

Disable legacy force to utf8 which break backend for xmlrpc. Needs te…

7a7119e

…sting with jsonrpc. Reinsert recently pruned parse_qs helper in xmlrpcbackup example.

Fix binary download handling and polish examples for cleaner output i…

2e30ac1

…n the general xmlrpc client example. Add text-mode cat for symmetry with binary. Show the actual error from jobstatus for sites where jobs are disabled.

Simplify fqdn and port handling a bit to also address a style issue r…

ba3d8f8

…eported in github actions. Bump at-job date to far future.

jonasbardino marked this pull request as ready for review July 16, 2026 09:19

jonasbardino changed the title ~~xmlrpc client and server updates~~ xmlrpc client and server updates to make examples functional again Jul 16, 2026

jonasbardino requested a review from a team July 16, 2026 09:25

jonasbardino added this to the Python3 support for general research data sites milestone Jul 16, 2026

jonasbardino added the battle-tested Code was tested to be fully functional in line with project code guidelines. label Jul 16, 2026

jonasbardino added a commit that referenced this pull request Jul 16, 2026

Pull in fixes and polish from #595 xmlrpc client.

685f62e

jonasbardino added a commit that referenced this pull request Jul 16, 2026

Pull in the rpcfunctions.py fixes from #595 also needed here.

b9b34f1

jonasbardino added 2 commits July 16, 2026 12:27

Drop ancient python 2.6 compatibility and use absolute imports in xml…

1d031a0

…rpcX examples relying on the shared connection init from xmlrpcsslclient.

Refactor SafeCertTransport to handle ssl_ctx init consistently an…

d9a0eee

…d enable reuse in the `xmlrpc.client.ServerProxy` calls.

jonasbardino added a commit that referenced this pull request Jul 16, 2026

Refactor SafeCertTransport to handle ssl_ctx init consistently an…

7f0d327

…d enable reuse in the `xmlrpc.client.ServerProxy` calls like we do in #595 now.

Avoid potential use of _connection before init.

5b38244

Martin-Rehr reviewed Jul 28, 2026

View reviewed changes

Comment thread mig/user/xmlrpcsslclient.py

Martin-Rehr reviewed Jul 28, 2026

View reviewed changes

Comment thread mig/user/xmlrpcsslclient.py

Martin-Rehr reviewed Jul 28, 2026

View reviewed changes

Comment thread mig/user/xmlrpcsslclient.py Outdated

Martin-Rehr reviewed Jul 28, 2026

View reviewed changes

Comment thread mig/user/xmlrpcsslclient.py

Martin-Rehr approved these changes Jul 28, 2026

View reviewed changes

Martin-Rehr reviewed Jul 29, 2026

View reviewed changes

Comment thread mig/shared/rpcfunctions.py

Martin-Rehr reviewed Jul 29, 2026

View reviewed changes

Comment thread mig/shared/rpcfunctions.py

Martin-Rehr reviewed Jul 29, 2026

View reviewed changes

Comment thread mig/shared/rpcfunctions.py

Martin-Rehr reviewed Jul 29, 2026

View reviewed changes

Comment thread mig/shared/rpcfunctions.py

jonasbardino added 2 commits July 29, 2026 14:22

Address issue from review feedback (thanks @Martin-Rehr).

c8c7083

Address a couple of issues from review feedback (thanks @Martin-Rehr).

9e39f7c

* Change the `main` function calling error to use and return `output_object`. * Drop unused `force_utf8_rec` helper function along with a few bare `except` lint fixes.

Address review feedback (thanks @Martin-Rehr) to handle the optional …

c120c7e

…`cacert` conf value with more care. Added a docstring line about it, too.

jonasbardino added the follow-up pending Pending tasks to follow-up on after close label Jul 30, 2026

jonasbardino added a commit that referenced this pull request Jul 30, 2026

Address a few review feedback suggestions (thanks @Martin-Rehr) like in

d9fe9c5

#595: add more robust `cacert` conf handling and add missing retval unpacking.

Wrap a long line introduced in last commit.

d4066ee

jonasbardino merged commit c5ff531 into next Jul 30, 2026
11 checks passed

jonasbardino deleted the adjust/xmlrpc-client-and-server-updates branch July 30, 2026 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

xmlrpc client and server updates to make examples functional again - #595

xmlrpc client and server updates to make examples functional again#595
jonasbardino merged 13 commits into
nextfrom
adjust/xmlrpc-client-and-server-updates

jonasbardino commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martin-Rehr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonasbardino commented Jul 29, 2026

Uh oh!

jonasbardino commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jonasbardino commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martin-Rehr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonasbardino commented Jul 29, 2026

Uh oh!

jonasbardino commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants