Enforce configured peer requirements in accountreq helper for all reqs

[jonasbardino]

Make sure the accept_account_req helper from accountreq always enforces any configured peer requirements even if the request handled lacks valid peer fields. This may or may not fix the issues reported in #586.

Extends the unit test suite with regression tests to cover a few cases of invalid or missing peers in combination with mandatory peer configuration.

Also makes sure that the various renewal and password reset tests cover the relevant 'temporal' account status rather than the empty default (interpreted as 'active').

Fast-forward a few unit tests to use the latest usersupp helpers to limit code duplication.

[Martin-Rehr]

The changes looks sane but it seems like there is an issue in mig/lib/janitor.py:319:

if accept_account_req(req_id, configuration, peer_id, ...):
    _logger.info("accepted authorized %r access renew" % client_id)
else:
    _logger.warning("failed authorized %r access renew" % client_id)

accept_account_req returns a 2-tuple a non-empty tuple is evaluated to True, so the else is never reached ?

[jonasbardino]

The changes looks sane but it seems like there is an issue in mig/lib/janitor.py:319:

if accept_account_req(req_id, configuration, peer_id, ...):
    _logger.info("accepted authorized %r access renew" % client_id)
else:
    _logger.warning("failed authorized %r access renew" % client_id)

accept_account_req returns a 2-tuple a non-empty tuple is evaluated to True, so the else is never reached ?

Yes, I've already found and fixed it in 630acfa but thanks.

We can pull that particular fix in here as well to fast-track it if you like?