Repository navigation
Conversation
When a netlink request is acknowledged by the kernel (e.g. NL_CB_ACK received), cb_done() transitions the request state to STATE_REPLIED. However, because standard ACK messages carry no payload attributes, st.res remains NULL. Previously, both uc_nl_request() in rtnl and uc_nl_request_common() in nl80211 returned st.res directly under STATE_REPLIED, evaluating to null in ucode script context. This contradicts both the documented return type (@returns {Object|boolean} ... or true for successful acknowledgment without data) and the STATE_UNREPLIED case which already returns true. As a result, scripts checking if (!ret) or comparing against true falsely treat a successful request as a failure. Return ucv_boolean_new(true) when st.state is STATE_REPLIED and st.res is NULL, properly signaling success when acknowledged by the kernel. Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
Author
|
@nbd168 cc |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a netlink request is acknowledged by the kernel (e.g. NL_CB_ACK received), cb_done() transitions the request state to STATE_REPLIED. However, because standard ACK messages carry no payload attributes, st.res remains NULL.
Previously, both uc_nl_request() in rtnl and uc_nl_request_common() in nl80211 returned st.res directly under STATE_REPLIED, evaluating to null in ucode script context. This contradicts both the documented return type (@returns {Object|boolean} ... or true for successful acknowledgment without data) and the STATE_UNREPLIED case which already returns true. As a result, scripts checking if (!ret) or comparing against true falsely treat a successful request as a failure.
Return ucv_boolean_new(true) when st.state is STATE_REPLIED and st.res is NULL, properly signaling success when acknowledged by the kernel.