Skip to content

lib: optimize trim(), ltrim(), rtrim() #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jow- merged 1 commit into from
Oct 8, 2026
Merged

lib: optimize trim(), ltrim(), rtrim() #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2424,8 +2424,8 @@ uc_trim_common(uc_vm_t *vm, size_t nargs, bool start, bool end)
{
uc_value_t *str = uc_fn_arg(0);
uc_value_t *chr = uc_fn_arg(1);
const char *p, *c;
size_t len;
const char *o, *p, *c;
size_t olen, len;

if (ucv_type(str) != UC_STRING ||
(chr != NULL && ucv_type(chr) != UC_STRING))
Expand All @@ -2434,8 +2434,8 @@ uc_trim_common(uc_vm_t *vm, size_t nargs, bool start, bool end)
c = ucv_string_get(chr);
c = c ? c : " \t\r\n";

p = ucv_string_get(str);
len = ucv_string_length(str);
o = p = ucv_string_get(str);
olen = len = ucv_string_length(str);

if (start) {
while (*p) {
Expand All @@ -2456,6 +2456,9 @@ uc_trim_common(uc_vm_t *vm, size_t nargs, bool start, bool end)
}
}

if (o == p && olen == len)
return ucv_get(str);

return ucv_string_new_length(p, len);
}

Expand Down
Loading