Skip to content

moveHandler: Remove the monitor grace period timer when a grab ends #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilMeyr wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

moveHandler: Remove the monitor grace period timer when a grab ends #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tiling-assistant@leleat-on-github/src/extension/moveHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,14 @@ export default class TilingMoveHandler {
this._dragSprite = null;
}
} finally {
// The grace period timer captures `window`, so leaving it pending
// lets it re-enter _edgeTilingPreview() after the window was
// unmanaged, which aborts mutter.
if (this._latestMonitorLockTimerId) {
GLib.Source.remove(this._latestMonitorLockTimerId);
this._latestMonitorLockTimerId = null;
}

if (this._posChangedId) {
window.disconnect(this._posChangedId);
this._posChangedId = 0;
Expand Down Expand Up @@ -488,7 +496,9 @@ export default class TilingMoveHandler {
// Only update the monitorNr, if the latest timer timed out.
if (timerId === this._latestMonitorLockTimerId) {
this._monitorNr = global.display.get_current_monitor();
if (global.display.is_grabbed())
// is_grabbed() is about the display, not about `window`
// still being managed.
if (global.display.is_grabbed() && window.get_compositor_private())
this._edgeTilingPreview(window, grabOp);
}

Expand Down
Loading