Skip to content

Fix: apply gaps to half-tiles when maximize-with-gap is enabled #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-kassai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: apply gaps to half-tiles when maximize-with-gap is enabled #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tiling-assistant@leleat-on-github/src/extension/tilingWindowManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,19 @@ export class TilingWindowManager {
);
}

if (verticalMaximize) {
// When maximize-with-gap is enabled, skip the VERTICAL/HORIZONTAL maximize
// flag: Meta's maximize snaps the window to the full work-area extent and
// ignores the gapped rect computed by addGaps(), so half-tiles lose their
// top/bottom (or left/right) gaps. Fall through to the override_constraints
// path used by quarter-tiles, which preserves gaps. Mirrors the
// full-maximize-with-gap handling above.
Comment on lines +241 to +243

@aleasto aleasto Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more concerned with what happens if window.override_constraints does not exist (i.e. on non-Ubuntu)?

const gappedTile = Settings.getBoolean('maximize-with-gap');
if (verticalMaximize && !gappedTile) {
if (window.set_maximize_flags)
window.set_maximize_flags(Meta.MaximizeFlags.VERTICAL);
else
window.maximize(Meta.MaximizeFlags.VERTICAL);
} else if (horizontalMaximize) {
} else if (horizontalMaximize && !gappedTile) {
if (window.set_maximize_flags)
window.set_maximize_flags(Meta.MaximizeFlags.HORIZONTAL);
else
Expand Down
Loading