fix(controller): preserve AllTargetsFiles change types for BUG-015 - #298
fix(controller): preserve AllTargetsFiles change types for BUG-015#298sbalabanov wants to merge 1 commit into
Conversation
|
|
sbalabanov
left a comment
There was a problem hiding this comment.
Simplify the PR description, include use case example of the bug the PR fixes
|
Simplified the PR description and added a concrete [addressed by agent] |
Summary: BUG-015 preserves protocol ChangeType semantics when an AllTargetsFiles global trigger fires. Intent: - Keep revision membership changes distinguishable from global invalidation. - Return complete old and new target payloads for targets present in both revisions. Changes: - Retain ordinary NEW and DELETED results before promoting shared targets to distance-zero CHANGED. - Apply identical classification behavior to chunk-backed and TGB-backed comparisons. - Cover stable, hash-changed, added, and deleted targets across both graph formats. --- <sub>Generated by the 🪄 pr-create skill in devexp-agent-marketplace</sub>
1eeb5a1 to
d307022
Compare
xytan0056
left a comment
There was a problem hiding this comment.
could you add an integration test for such behavior in
https://github.com/xytan0056/bazel-fixture/pulls
and expand the testcase here ?
why would the fixture go to a private fork? Also for e2e test, it might be a separate diff if we did not test all-in files before. |
Summary
Fix BUG-015 by preserving
NEWandDELETEDchange types when anAllTargetsFilesglobal trigger changes.Previously, global invalidation could overwrite every result as
CHANGED. For example, if.bazelrcchanges in the same revision that adds//service:newand deletes//service:old, callers must still receiveNEWfor the added target andDELETEDfor the removed target; only targets present in both revisions should be promoted to distance-zeroCHANGED.The fix applies the same classification behavior to chunk-backed and TGB-backed graph comparisons.
Test Plan
Issues
T3-BUG-015