feat(stovepipe): request history api - by request ID - #670
Open
mnoah1 wants to merge 2 commits into
Open
Conversation
This was referenced Sep 2, 2026
mnoah1
force-pushed
the
mnoah1/stovepipe-history-by-id
branch
from
September 3, 2026 00:37
f2e8410 to
a9ab6f0
Compare
Summary: Intent: - Serve retained history by request ID without consulting operational request data. - Preserve domain-level invalid and missing-history classifications for future transports. Changes: - Add the request-history controller and bounded selector validation. - Read only the queue-scoped request log and preserve context metric tags. - Cover successful, invalid, missing, and infrastructure outcomes. This PR builds on #669, which defines the retained-history read model. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
force-pushed
the
mnoah1/stovepipe-history-by-id
branch
from
September 3, 2026 00:39
a9ab6f0 to
8f53ed1
Compare
mnoah1
changed the title
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
September 3, 2026 01:04
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 3, 2026 01:04
sbalabanov
approved these changes
Sep 4, 2026
|
|
||
| func (c *requestHistoryController) readHistoryByID(ctx context.Context, req entity.GetRequestHistoryByIDRequest) ([]entity.RequestLog, error) { | ||
| if err := validateHistoryIdentifier("queue", req.Queue); err != nil { | ||
| return nil, fmt.Errorf("GetRequestHistoryByID invalid queue: %w", err) |
Contributor
There was a problem hiding this comment.
include queue name from the request
| return nil, fmt.Errorf("GetRequestHistoryByID invalid queue: %w", err) | ||
| } | ||
| if err := validateHistoryIdentifier("request ID", req.ID); err != nil { | ||
| return nil, fmt.Errorf("GetRequestHistoryByID invalid request: %w", err) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Stack