Skip to content

fix(errs): Retry transient grouped failures - #621

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/classify-joined-errors
Aug 24, 2026
Merged

fix(errs): Retry transient grouped failures#621
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/classify-joined-errors

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Retry work when any one of several failures reported together is transient instead of giving up on the first attempt.
  • Limit a classification attached to one grouped failure to that failure alone, instead of letting it decide the outcome for the others reported alongside it.

Why:

  • Stop discarding failures that would have cleared on their own by keeping a step that fans work out to several handlers from being abandoned because one handler hit a momentary error.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. The changes in this PR are confined to the error classification framework.

Issues

@prathshenoy
prathshenoy marked this pull request as ready for review August 19, 2026 19:23
@prathshenoy
prathshenoy enabled auto-merge August 19, 2026 19:23
mnoah1
mnoah1 reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/errs/processor.go
@prathshenoy
prathshenoy force-pushed the prath.shenoy/classify-joined-errors branch from 33e11c5 to 31ce24d Compare August 20, 2026 22:03
@prathshenoy
prathshenoy marked this pull request as draft August 20, 2026 22:12
auto-merge was automatically disabled August 20, 2026 22:12

Pull request was converted to draft

@prathshenoy
prathshenoy force-pushed the prath.shenoy/classify-joined-errors branch 2 times, most recently from f3b2d0a to 09f0cd9 Compare August 21, 2026 16:20
@prathshenoy
prathshenoy marked this pull request as ready for review August 21, 2026 16:21
behinddwalls
behinddwalls previously requested changes Aug 21, 2026
View reviewed changes
Comment thread platform/errs/processor.go
Comment thread platform/errs/processor.go Outdated
Comment thread platform/errs/processor.go Outdated
behinddwalls
behinddwalls reviewed Aug 21, 2026
View reviewed changes
Comment thread platform/errs/processor.go Outdated
behinddwalls
behinddwalls reviewed Aug 21, 2026
View reviewed changes
Comment thread platform/errs/README.md Outdated
behinddwalls
behinddwalls reviewed Aug 21, 2026
View reviewed changes
Comment thread platform/errs/README.md Outdated
@prathshenoy
prathshenoy force-pushed the prath.shenoy/classify-joined-errors branch from 09f0cd9 to 5e10cb1 Compare August 24, 2026 04:46
@prathshenoy
prathshenoy enabled auto-merge August 24, 2026 15:35
@prathshenoy
prathshenoy force-pushed the prath.shenoy/classify-joined-errors branch from 5e10cb1 to 4d9d686 Compare August 24, 2026 15:41
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit d74bc8c Aug 24, 2026
15 checks passed
@prathshenoy
prathshenoy deployed to stack-rebase August 24, 2026 15:51 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the prath.shenoy/classify-joined-errors branch August 24, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner

Assignees

No one assigned

Labels

AutoMerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prathshenoy @behinddwalls @mnoah1