Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ integration-test-submitqueue-orchestrator: ## Run Orchestrator integration tests
license-fix: ## Add missing license headers to source files
@$(BAZEL) run //tool/linter/licenseheader -- --fix

lint: lint-fmt lint-license ## Run all linters
lint: lint-fmt lint-license lint-queue-shard ## Run all linters
@echo "All lint checks passed."

lint-fmt: fmt ## Check code formatting (fails if unformatted)
Expand All @@ -182,6 +182,9 @@ lint-fmt: fmt ## Check code formatting (fails if unformatted)
lint-license: ## Check license headers on all source files
@$(BAZEL) run //tool/linter/licenseheader -- --check

lint-queue-shard: ## Check every table's primary key leads with the queue column
@$(BAZEL) run //tool/linter/queueshard

local-submitqueue-clean: ## Stop and remove all local services, volumes, and images
@echo "Cleaning all services and data..."
@$(COMPOSE) -f $(COMPOSE_FILE) -p $(SUBMITQUEUE_LOCAL_PROJECT) down -v --rmi local
Expand Down
15 changes: 15 additions & 0 deletions api/submitqueue/gateway/proto/gateway.proto
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ message CancelRequest {
string sqid = 1;
// Optional human-readable reason for the cancellation. Recorded for observability.
string reason = 2;
// Name of the queue processing the request. Required. A sqid is only resolvable within its own queue,
// so naming a queue the request does not belong to is reported as not found.
string queue = 3;
}

// CancelResponse defines the response to a cancel request. Empty on success.
Expand Down Expand Up @@ -106,6 +109,9 @@ message RequestSummary {
message GetRequestSummaryByIDRequest {
// Globally unique identifier for the request.
string sqid = 1;
// Name of the queue processing the request. Required. A sqid is only resolvable within its own queue,
// so naming a queue the request does not belong to is reported as not found.
string queue = 2;
}

// GetRequestSummaryByIDResponse contains the current materialized request view.
Expand All @@ -118,6 +124,9 @@ message GetRequestSummaryByIDResponse {
message GetRequestSummaryByChangeURIRequest {
// Exact change URI supplied in a Land request.
string change_uri = 1;
// Name of the queue to search. Required. Results are scoped to this queue: a change URI landed
// into several queues is looked up one queue at a time.
string queue = 2;
}

// GetRequestSummaryByChangeURIResponse contains matching requests newest first.
Expand Down Expand Up @@ -152,6 +161,9 @@ message ListResponse {
message GetRequestHistoryByIDRequest {
// Globally unique identifier for the request.
string sqid = 1;
// Name of the queue processing the request. Required. A sqid is only resolvable within its own queue,
// so naming a queue the request does not belong to is reported as not found.
string queue = 2;
}

// HistoryEvent is one retained append-only request-log event.
Expand All @@ -176,6 +188,9 @@ message GetRequestHistoryByIDResponse {
message GetRequestHistoryByChangeURIRequest {
// Exact change URI supplied in a Land request.
string change_uri = 1;
// Name of the queue to search. Required. Results are scoped to this queue: a change URI landed
// into several queues is looked up one queue at a time.
string queue = 2;
}

// RequestHistory groups retained events for one request.
Expand Down
85 changes: 70 additions & 15 deletions api/submitqueue/gateway/protopb/gateway.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading