website: switch all dependencies to devDependencies - #1206
Open
isaacbrodsky wants to merge 4 commits into
Open
Conversation
|
coverage: 99.7%. remained the same — isaacbrodsky:website-devdeps into uber:master |
dfellis
approved these changes
Jul 31, 2026
nrabinowitz
approved these changes
Aug 7, 2026
nrabinowitz
left a comment
nrabinowitz
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--frozen-lockfilein CIyarn upgradedevDependencies.For the devDependencies part, my rationale is that this code is only run in CI or on developer machines. In deploy-website.yml, we only use the HTML output of Docusaurus. This approach looks consistent with Docusaurus's recommendation: e.g. facebook/docusaurus#5501 I'd also hope this cuts down on the number of Dependabot PRs we receive here.
#1203 Thanks @brettshearer for pointing out we can improve this.