fix(discovery): redact joined credential arguments - #113
Merged
Conversation
Handle joined short-option operands and credential-like key=value assignments while preserving noncredential assignments. Reported-by: Syed Anas Mohiuddin
pengyuzhang
force-pushed
the
fix/discovery-argv-redaction
branch
from
August 30, 2026 20:01
a0babfe to
c3ad477
Compare
lghupan
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (reported directly)
What changed?
Why?
Discovery previously handled separated credential operands and dashed flag=value forms, but common CLI conventions could leave credential values in collected process argv.
Thank you to Syed Anas Mohiuddin, independent security researcher, for reporting the gap and recommending coverage for joined short options and key=value arguments.
How did you test it?
Potential risks
Credential-key matching is intentionally conservative and may redact some values whose key contains a credential term. Joined handling is limited to the existing short credential flags to bound over-redaction.