Fill in default config values when key is missing from database#776
Merged
Conversation
Previously we'd just use an empty object, but this might not be a valid value if the schema specifies required properties. If those required properties have defaults, we can fill them in like this. Also verify that an empty object is valid for every registered config schema, so you can't have a schema that would cause errors when the client tries to render it.
|
coverage: 68.408% (+0.04%) from 68.367% — fill-config-defaults into default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we'd just use an empty object, but this might not be a valid
value if the schema specifies required properties. If those required
properties have defaults, we can fill them in like this.
Also verify that an empty object is valid for every registered config schema,
so you can't have a schema that would cause errors when the client tries to render it.