Suppresses RLC non-final field overwrite warning for safe constructor field initialization

[iamsanjaymalakar]

Summary by CodeRabbit

• New Features

  • Enhanced resource leak checker to suppress false-positive warnings when a private field is assigned for the first time within a constructor.

• Tests

  • Added comprehensive test suite covering various constructor initialization scenarios, including inline initializers, instance initializers, method calls, and conditional branching.

[kelloggm]

Overall looks good, just a few minor comments. I'd like to take one more look before we merge, though.

[mernst]

@iamsanjaymalakar The typecheck job is not passing.

[kelloggm]

LGTM, I don't need to review again. Please address these comments and then request a review from Mike.

[mernst]

@iamsanjaymalakar Martin asked you to assign me when you had addressed his comments. Have you addressed them?

[iamsanjaymalakar]

@iamsanjaymalakar Martin asked you to assign me when you had addressed his comments. Have you addressed them?

Yes, I have. You can take a look.

[mernst]

Please clarify some documentation, and update the code if necessary. (I didn't read the code because there is no point in doing so until the documentation is clear.)

[mernst]

Thanks! This is looking solid. I have a few comments and questions, and then after another round I hope this can be merged.

[mernst]

I don't see how it would turn into a CFG dependency.

[mernst]

I don't see that handling branches requires control-flow reasoning or a control-flow graph. It can be done purely (and simply) in the AST. If you don't want to do it, that is one thing, but please provide the correct rationale.

I think the wording you are looking for is "lexically first"; "AST-only" does not convey anything to me.

[mernst]

@iamsanjaymalakar When you address a code review comment, please mark it as "resolved" so that we know its status and it does not clutter this code review webpage.