fix: honor TLS verification settings in HTTP clients - #142
Open
abhinavrastogi2627 wants to merge 1 commit into
Open
abhinavrastogi2627 wants to merge 1 commit into
abhinavrastogi2627 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass the existing
Configuration.verifyvalue to HTTPX when constructing both API clients. After the HTTPX migration, this setting was stored but ignored, so custom CA bundles and explicitverify=Falsehad no effect. The default remains certificate verification enabled.The async source is updated and the sync source regenerated with
utils/run-unasync.py. Eight regression cases exercise both clients: effective TLS verification modes, loading a configured CA bundle through the real SSL context builder, and rejection of a missing CA file. Six of those cases fail on the unchanged base.Fixes #139. This addresses runtime forwarding; the
ConfigDict.verifyannotation change remains covered separately by #136.Validation
uv run ruff check src/typesense tests/api_call_ssl_test.pyuv run mypy src/typesense: no issues in 104 source files.uv run python utils/run-unasync.py --checkThe full Typesense-server integration suite was not run. String CA paths retain HTTPX 0.28.1's existing deprecation warning; this change does not alter HTTPX's accepted verification values.