Repository navigation
Declare transitions locally with branches, stay, commands, and update records - #268
Merged
Merged
Conversation
… records Move conditional destinations from make into an inline branches list that the compiler checks against resolve in both directions, so one transition can be edited without reading anything else. Replace none with stay, add commands to plain transitions, and make update a record so data only ever means the target's value. Restrict guard and decline to on and always, which have another candidate to fall through to. Retained branch keys are now the entry as written. Retire no-redundant-resolve, which the compiler now covers, and port the conditional rule to stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change across all four packages. Each transition now holds everything needed to read and edit it.
branchesmoves frommakegroups into a list next toresolve.select.target(path, ...),select.update,select.history,select.initialize,select.stay, andselect.declinereplaceselect.<key>, and the compiler checks the calls against the list in both directions. Branch keys,declinable, branchtitle, and thedeclinecontext function are gone.{ stay: true }and{ reenter: true }replacenone.{ none: true, resolve }becomes{ stay: true, commands }.commandsworks on every plain transition.update: { owner: value }is a record with one owner, sodataonly ever means the target's value. Abranchesentry names the owner as a string.guardanddeclineexist only ononandalways, in types and at runtime. A declined invocation outcome used to strand the machine.staypreempting a parallel ancestor's handler is existing behaviour, now documented and covered by a public test and a differential case.Errors name the fix, for example
resolve selects undeclared { stay: true }. Add it to branches. The exactness check also rejectsundefined,Promise,any,unknown, duplicate entries, and widened paths.Choices made while building this:
branchKeyand definitionkeystay, derived from the entry as written (target:Paid,update:root,stay). Coverage andMachineTest.checktherefore name branches without an authored key.no-conditional-none-branchis ported tono-conditional-stay-branchrather than retired, because it still catches a real bug: a disabled control thatMachine.canreports as enabled. It flagged a devtools example while I migrated it.no-redundant-resolveis retired.Type-performance tradeoff: most scenarios are flat or slightly lower.
declared transition (10 named branches)rises about 11% andparallel/history/choiceabout 12%, which pays for checkingresolveagainstbranchesand owners by path. This is deliberate, perAGENTS.md.Changeset
Validation
pnpm check🤖 Generated with Claude Code