Repository navigation
Potential bug in propagation of OpenTelemetry #1190
Description
While working on #1185 I checked if OpenTelemetry backend suffers from the same issue and it appeared it doesn't but I've spotted suspicious use of Context.current() like here and other places:
Since Context.current() is implemented using ThreadLocal, with cats-effect this would return effectively random context.
According to extract documentation it will merge information extracted from the kernel with passed in context.
So the spanId/traceId will be correct but there is a risk of polluting context with other information from wrong thread (maybe coming from instrumentation agents or third party Java code that uses otel?).
Not sure how important this is in practice but I think Context should be propagated with OpenTelemetrySpan, created with Context.root() in entrypoints and also activated in #1189.
I don't really use it so I might be wrong.
Activity
mwisnicki commentedon Jun 30, 2025
Actually unless something else called
Context#makeCurrentthere will be no current context so we getContext.root()every time we callContext.current().Right now nothing in natchez calls
makeCurrentbut this would change with #1189.It's also possible for context to be created and made current by instrumentation agents for supported Java frameworks, for example when using http4s-netty.