Skip to content

Make MappingValidator stack safe - #940

Merged
hugo-vrijswijk merged 2 commits into
typelevel:mainfrom
rpiaggio:stack-safe-mapping-validator
Sep 8, 2026
Merged

Make MappingValidator stack safe#940
hugo-vrijswijk merged 2 commits into
typelevel:mainfrom
rpiaggio:stack-safe-mapping-validator

Conversation

@rpiaggio

@rpiaggio rpiaggio commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Use Eval instead of Id to keep MappingValidator stack safe.

In a schema with 30+k lines this got to be an issue.

@hugo-vrijswijk hugo-vrijswijk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Apart from a scalafmt issue

@rpiaggio

rpiaggio commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

LGTM! Apart from a scalafmt issue

Solved

@hugo-vrijswijk
hugo-vrijswijk merged commit 7d9ac37 into typelevel:main Sep 8, 2026
13 checks passed
@hugo-vrijswijk

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants