Repository navigation
Expose @glint/template utility types - #285
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the pending items from #283 is providing projects using native imports and signatures with a way to describe the type of yielded components, as
@glint/environment-ember-loose'sComponentLikecurrently does. This is a vital piece for describing the signature of components that do things like:Now that signature formats have been more or less standardized across the board, we can expose standardized
ComponentLike,HelperLikeandModifierLiketypes from@glint/templateitself rather than homing them in an environment-specific location. Subclasses ofComponent,HelperandModifierare respectively assignable to their corresponding*Liketypes, as are the return values fromhelper()andmodifier().Each of these types is compatible as the first argument of a new
WithBoundArgshelper, which will return an equivalent type except for any named args mentioned in the second argument being made optional. Capturing the above template example in a signature:The
@glint/templatepackage is a types-only package that provides the baseline type declarations that all Glint environments are based on, and as such is something that addons can declare a dependency on without having any (even theoretical) runtime impact on their consumers.