docs(minibf): document endpoints missing from coverage table - #1336
Conversation
Add the three MiniBF routes that were hooked in the router but never
listed in the Coverage table:
- /utils/addresses/xpub/{xpub}/{role}/{index} (added in #1278)
- /governance/proposals/{tx_hash}/{cert_index}/metadata (added in #1295)
- /governance/proposals/{gov_action_id}/metadata (added in #1295)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Minibf API documentation adds coverage rows for two governance proposal metadata endpoints and one xpub address derivation endpoint. ChangesMinibf API coverage
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change only adds coverage entries for existing endpoints and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Documents three previously omitted minibf API routes in the coverage table.
Changes:
- Added two governance proposal metadata endpoints.
- Added the xpub address derivation endpoint.
File summaries
| File | Description |
|---|---|
docs/content/apis/minibf.mdx |
Documents the three missing minibf routes. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Resolves #1337.
Add the missing
minibfroutes that were hooked in the router but never listed in the Coverage table:/utils/addresses/xpub/{xpub}/{role}/{index}/utils/addresses/xpub/{xpub}/{role}/{index}#1278/governance/proposals/{tx_hash}/{cert_index}/metadata/governance/proposals/*/metadataroutes #1295/governance/proposals/{gov_action_id}/metadata/governance/proposals/*/metadataroutes #1295Summary by CodeRabbit