Skip to content

Make tabs visible in overflow menu when window is too narrow #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bunnyhero wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make tabs visible in overflow menu when window is too narrow #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/AppView/AppView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ struct AppView: View {
.padding()
}
.tabItem {
Text("App")
Label("App", systemImage: "plus.app")
}
.alert(isPresented: $shouldShowUninstallConfirmationAlert) {
Alert(title: Text("Are you sure you want to permanently delete \(selectedApplication.displayName)"),
Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/ColorsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ struct ColorsView: View {
}
.padding()
.tabItem {
Text("Colors")
Label("Colors", systemImage: "paintpalette")
}
}

Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/LocationVIew/LocationView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ struct LocationView: View {
}
}
.tabItem {
Text("Location")
Label("Location", systemImage: "location.fill")
}
.padding()
.onReceive(jitterTimer) { _ in
Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/OverridesView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ struct OverridesView: View {
.padding()
}
.tabItem {
Text("Overrides")
Label("Overrides", systemImage: "switch.2")
}
}

Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/SnapshotsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ struct SnapshotsView: View {
}
}
.tabItem {
Text("Snapshots")
Label("Snapshots", systemImage: "camera")
}
.sheet(item: $snapshotAction) { action in
switch action {
Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/StatusBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ struct StatusBarView: View {
.padding()
}
.tabItem {
Text("Status Bar")
Label("Status Bar", systemImage: "bolt.badge.clock")
}
}

Expand Down
2 changes: 1 addition & 1 deletion ControlRoom/Simulator UI/ControlScreens/SystemView/SystemView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ struct SystemView: View {
.padding()
}
.tabItem {
Text("System")
Label("System", systemImage: "gear")
}
.onAppear {
isLoggingEnabled = UserDefaults.standard.bool(forKey: "\(simulator.udid).logging")
Expand Down
1 change: 1 addition & 0 deletions ControlRoom/Simulator UI/ControlView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,6 @@ struct ControlView_Previews: PreviewProvider {
simulator: .example,
applications: [])
.environmentObject(Preferences())
.environmentObject(DeepLinksController())
}
}