UPN bind example: docstrings + light modernization (fixes #161) - #261
Merged
Merged
Conversation
Applies the review comments left on #161 (adiroiban) by extracting the UPN resolution into a well-documented ``_resolveUPNBindDN`` helper, explaining the ``@`` vs ``,`` shape check that identifies a UPN, and naming the two fall-through cases (not-a-UPN, no-unambiguous-match). Also drops a couple of Python 2 leftovers now that we require 3.10+: the explicit ``object`` base and ``super(Cls, self)``. Behaviour is unchanged; this is a docs-only example file, still exercised only by being importable. Co-authored-with: Thomas Grainger <tagrain@gmail.com>
adiroiban
approved these changes
Sep 3, 2026
adiroiban
left a comment
adiroiban
left a comment
Member
There was a problem hiding this comment.
Hi. Sorry for the delay. I just wanted to let you know that the coderabbit.ai GitHub app request was rejected.
Unfortunately, LLM tools are not welcomed in the Twisted Org repos.
See https://docs.twisted.org/en/latest/development/ai-policy.html
I have checked the changes an they look good.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #161. Rebased graingert's two commits onto current master,
and added a follow-up commit that applies the review comments left by
adiroiban on the original PR (docstring on the UPN helper, comment
wording on the two fall-through branches).