Repository navigation
Speed up the with tag by adding the globals to the new context in place - #5009
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
stof
reviewed
Oct 20, 2026
nicolas-grekas
force-pushed
the
with-tag-globals-merge-3x
branch
from
October 20, 2026 12:09
7edd2d8 to
b15f080
Compare
stof
approved these changes
Oct 20, 2026
nicolas-grekas
force-pushed
the
with-tag-globals-merge-3x
branch
from
October 27, 2026 14:30
b15f080 to
60d1921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$vars + $context + $this->env->getGlobals()copies the whole context twice. Adding the globals in place saves one copy perwithtag, 2.2k instructions with a context of 40 variables.