[pull] master from ruby:master#1170
Merged
Merged
Conversation
As well as `FileUtils.ln_sr`.
The example built a gem on disk, and util_build_gem writes every entry of spec.files, which includes spec.extensions. On Windows the extension name embedding a newline cannot become a file name, so the example was skipped and the check went uncovered. Build the installer from the spec in memory with Installer.for_spec instead, matching the sibling non_string checks, so verify_spec still runs before the spec is eval'd without the newline ever reaching the disk. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The `target_directory` option does not make sense unless the target is not a directory.
So it could feasibly be enabled and sampled in production
Co-authored-by: John Hawthorn <john@hawthorn.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )