[pull] master from ruby:master#1155
Merged
Merged
Conversation
Emitting a Send in `type_specialize` makes the compiler require more phases to go and optimize that Send. Instead, in HIR build, emit either a) a guard or b) a run-time type check that might get specialized away. Also delete `ObjToString`.
The resulting type of a `GuardType` we prove cannot pass is `Empty`. Any HIR instructions using the type information from the `GuardType` will also see `Empty` and propagate that type through the compiler. Any generated code would not be executable at run time due to the always failing guard, so there's no point in generating it.
An `Empty` value has no representable size. The caller trying to get the size is operating on an unreachable instruction that should have already been removed.
Good for the humans and agents.
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
* ZJIT: Reuse instruction profiling for recompile exits Deduplicate recompile-exit profiling by sharing the per-instruction profiling logic used by zjit_* instructions. Recompile exits now use the materialized CFP state to recover the current instruction and collect profiles through profile.rs, instead of passing kind-specific profiling payloads across the C ABI. * ZJIT: Restore HIR Recompile struct Keep HIR recompilation metadata as Option<Recompile> instead of a bool. This preserves a typed extension point for future recompilation policy without changing the shared recompile-exit profiling path.
Commit 0ea210d renamed ROBJECT_IVPTR to ROBJECT_FIELDS, so it would have caused compatibility issues anyways. Since there has been no issues, it means that nobody is using it. We can make this dangerous API private since no C extension should be using it anyways.
* ZJIT: Add perf symbol for block padding * ZJIT: Explain HIR-only padding perf symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )