[pull] master from ruby:master#1149
Merged
Merged
Conversation
Also introduce printing helper for writing separated lists in `Display` impl for `Insn`.
Skip intermediate GetIvar and optimize straight through, either from getinstancevariable opcode or from methods with METHOD_TYPE_IVAR.
Get rid of the CFUNC overhead in String#ascii_only? and #valid_encoding?. Define them as leaf Primitive.cexpr! builtins in a new string.rb, following the pattern of numeric.rb. This makes them 1.2x-1.4x faster across the interpreter, YJIT, and ZJIT. Move ZJIT's cfunc annotation for String#ascii_only? to annotate_builtin!, and add one for String#valid_encoding?. Fix CI for builtin String#ascii_only?
Read the cached coderange directly (flags & MASK) instead of calling the builtin: ascii_only? is == 7BIT, valid_encoding? is != BROKEN, side-exit on UNKNOWN. Drops the call, ~20% faster on ZJIT.
Since `src` is always a `fstring` we don't need to compare length nor content, we can just compare the pointers.
Bundler's required_rubygems_version (>= 3.4.1) always ships Gem::TSort, vendored into RubyGems since 3.4.0, so the duplicate Bundler::TSort copy is unnecessary. Delegate to rubygems/vendored_tsort and switch SpecSet to include Gem::TSort. ruby/rubygems@1a1f49b64b Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )