[pull] master from ruby:master#1143
Merged
Merged
Conversation
This isn't essential for correctness, however it's a natural time to investigate whether the heap is in a correct state.
…re Ruby fallback The snake_case aliases (escape_html, h, unescape_html) were defined before `require 'cgi/escape.so'`, so they captured references to the pure Ruby methods. After the C extension loads and prepends EscapeExt, only the camelCase names (escapeHTML, etc.) resolved to the fast C implementation — the aliases still called the ~10x slower Ruby path. Move alias definitions after the C extension loads, and define them on EscapeExt when available so they bind to the optimized C methods. ruby/cgi@97b055dab04a
The ascii-compatible path builds a binary buffer but returned numeric character references via chr(enc), so a non-ASCII replacement appended to a buffer that already held non-ASCII bytes raised Encoding::CompatibilityError. Decode into the binary buffer instead, matching the C extension's optimized_unescape_html for out-of-range references (kept verbatim, leading zeros included) and surrogate code points (emitted as raw bytes). ruby/cgi#103 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> ruby/cgi@09970b06d328
cargo builds in YJIT/ZJIT/Rust workflows intermittently fail when a crates.io download is truncated (curl [16] HTTP/2 framing, [18] partial transfer). Set CARGO_NET_RETRY and disable HTTP/2 multiplexing at the workflow level so every job that compiles Rust is covered, not just the zjit-ubuntu make job. https://github.com/ruby/ruby/actions/runs/28014276636/job/82914636268 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )