[pull] master from php:master#1034
Merged
Merged
Conversation
fputcsv() and next() reached the file stream without the CHECK_SPL_FILE_OBJECT_IS_INITIALIZED guard their siblings carry, so invoking them via reflection on an object from newInstanceWithoutConstructor() (constructor bypassed, stream NULL) crashed instead of throwing. next() only touches the stream with the READ_AHEAD flag, itself settable through the equally unguarded setFlags(). Both now throw "Object not initialized". Fixes GH-16217 Closes GH-22454
* PHP-8.4: Guard uninitialized SplFileObject in fputcsv() and next()
* PHP-8.5: Guard uninitialized SplFileObject in fputcsv() and next()
ReflectionClass::hasProperty() and getProperty() look the name up in the class's properties_info table and, on a match, return before checking the object's dynamic properties. A private property declared on a parent class lives in that table but isn't visible to the child, so a dynamic property of the same name went unreported. Fold the accessibility check into the lookup so an inaccessible private-parent match falls through to the existing dynamic-property check, matching property_exists(). Fixes GH-22441 Closes GH-22451
* PHP-8.4: Report dynamic property shadowing a private parent in Reflection
* PHP-8.5: Report dynamic property shadowing a private parent in Reflection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )