Skip to content

fix: address code review findings and update dependencies - #11

Merged
Andx667 merged 4 commits into
mainfrom
dev
Oct 1, 2026
Merged

Andx667 merged 4 commits into
mainfrom
dev

Conversation

@Andx667

@Andx667 Andx667 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Embed Roboto in PDF export so cs/pl/fr text renders (test checks all ARB characters are covered)
  • Keep the persistence write queue alive after a failed write
  • Confirm before restarting from the summary screen (new strings in all 7 locales)
  • Skip malformed custom rooms/devices when loading saved state
  • Cameras now also ask password/updates; locks ask updates
  • Reuse RiskLevel.fromScore, set PDF fileNameOverrides, pin intl
  • Update pdf, share_plus, msix and transitive dependencies
  • Build number bumped to 43

Test plan

  • flutter analyze clean
  • flutter test (55 tests) passing locally
  • CI: checks, Android APK and Windows builds

🤖 Generated with Claude Code

Andx667 and others added 4 commits October 1, 2026 15:51
- Implement a test to verify that the embedded PDF font covers every character of every locale by checking all ARB files in the localization directory.
- Add tests to ensure that cameras and locks correctly ask about updates and passwords.
- Create a test to validate that malformed custom entries in survey state are skipped without losing valid entries, ensuring proper loading from shared preferences.
- embed Roboto in PDF export so cs/pl/fr text renders
- keep persistence queue alive after a failed write
- confirm before restarting from the summary screen
- skip malformed custom rooms/devices when loading saved state
- ask password/updates for cameras and updates for locks
- reuse RiskLevel.fromScore, set PDF fileNameOverrides, pin intl
- bump build number to 43

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Andx667
Andx667 merged commit ddf9076 into main Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant