feat: add docker-credential-ecr-login to image - #54
Merged
Conversation
Signed-off-by: Guilherme Rezende <guilhermebr@gmail.com>
ravilock
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Adds the amazon-ecr-credential-helper
(v0.12.0, current latest) to the image, mirroring the existing
docker-credential-gcrsupport. This enables buildkit pushes to Amazon ECRusing ambient AWS credentials (IRSA / instance profile) via the standard docker
credHelpersconfig:{ "credHelpers": { "123456789012.dkr.ecr.us-east-1.amazonaws.com": "ecr-login" } }Notes:
linux-amd64andlinux-arm64paths — matching${TARGETARCH}directly,so both image platforms built by CI are covered. The build runs
docker-credential-ecr-login -vas a sanity check, like the existingdocker-credential-gcr versioncall.config.jsonat build time (
gcr configure-dockerhas a fixed set of well-known hosts toregister; ECR registry hosts are account/region-specific), so the
credHelpersentry is left to the operator's mounted docker config.API compatible with the Distribution protocol); operators typically attach an
ECR lifecycle policy to the repository prefix.
Validated in production: deploys on an EKS cluster pushing to ECR with IRSA
credentials and the
credHelpersconfig above — pushes authenticate with nostatic secrets.