fix(web-app): cap Omnibar modal height and scroll its body on short viewports - #286
Draft
tstapler wants to merge 1431 commits into
Draft
fix(web-app): cap Omnibar modal height and scroll its body on short viewports#286tstapler wants to merge 1431 commits into
tstapler wants to merge 1431 commits into
Conversation
State machine redesign + hibernation feature planning: - requirements.md: 4 epics (state machine, async creation, sub-status visibility, hibernation) - research/: stack, features, architecture, pitfalls - implementation/plan.md: 4 epics, 18 stories, 36 tasks - implementation/validation.md: 78 tests, 100% AC coverage - decisions/ADR-001: state machine redesign (5-state model) - decisions/ADR-002: hibernation checkpoint storage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ecture - Go type system research added (research/go-type-system-state-machine.md) - plan.md updated: state machine uses []TransitionDef with Guard/After hooks instead of flat map[Status][]Status - Added exhaustive linter task to Epic 1 - Added ent DB migration task with old→new integer remapping - Clean iota renumbering: Creating=0, Active=1, Paused=2, Stopped=3, Hibernated=4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Epic 1 Story 1.3: Instance Interface Redesign - Predicate methods (IsActive, IsHibernated, IsPaused, etc.) - Rename setStatus → loadStatus, restrict to deserialization only - Eliminate transitionTo fallback pattern (setStatus bypass) - Add context to transitionTo for guard cancellation - Update InstanceReader interface with typed Status and predicates - Remove NeedsApproval as lifecycle state (demoted to sub-status) - Replace RecoverFromStopped with normal Resume via state machine Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Creating=0, Active=1, Paused=2, Stopped=3, Hibernated=4. Deprecated aliases Running/Ready/Loading kept temporarily for compile compatibility. Adds _statusSentinel guard against iota reordering. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…usages Replaces session.Running and session.Ready references in server/services, pkg/events, server/analytics, session/workspace, and tests/demo with session.Active. Fixes ProtoToStatus to use integer literals for legacy wire values (READY=2, NEEDS_APPROVAL=5, LOADING=3) to avoid duplicate case errors from allow_alias. Removes unused _statusSentinel constant. All lint checks pass (make lint: exit 0). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…atus The CreateSession RPC now saves the instance with Creating status and returns immediately, then spawns a goroutine to call instance.Start(). On success the goroutine sets Active status; on failure it sets Stopped and records the error in creation_progress. Also adds the creation_progress = 51 proto field to the Session message and populates it from Instance.CreationProgress in instance_adapter.go. Adds ForceStatus() public method for error-recovery paths that cannot use the normal state-machine transition. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Generated Go and TypeScript bindings from the proto change in the previous commit. Session.creation_progress (field 51) is now accessible as Session.CreationProgress in Go and session.creationProgress in TypeScript. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ponent Backend (Epic 1 completion): - server/services/ai_interfaces.go: RulePromptBuilder, AIClient, RulePromptContext - server/services/rule_prompt_builder.go: DefaultRulePromptBuilder with secret redaction - server/services/anthropic_client.go: AnthropicAIClient (HTTP fallback) - server/services/rules_service.go: GenerateSuggestedRule handler, parseSuggestions, attachConflictInfo, buildPromptContext - server/services/approval_handler.go: redact secrets before analytics recording - config/config.go: AnthropicAPIKey field + ANTHROPIC_API_KEY env override Frontend (Epic 2): - web-app/src/lib/hooks/useGenerateRule.ts: wraps GenerateSuggestedRule RPC, manages suggestions[], loading, error, cancel (AbortController), 60s timeout - web-app/src/components/sessions/SuggestedRuleCard.tsx: shared card with confidence badge, conflict/shadow warnings, editable fields, Accept & Discard - web-app/src/components/sessions/SuggestedRuleCard.css.ts: vanilla-extract styles Tests: 13 Go unit + 21 frontend (9 hook + 12 card), all passing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(analytics): program detail panel with subcommand drill-down Add DB-backed time-windowed analytics queries and an inline program detail panel so operators can see exactly which sub-operations are causing escalations before writing a rule. Backend (Go): - Add compound index on (command_program, created_at) to ent schema - Replace full-table-scan ListAnalytics with time-windowed ListAnalyticsSince (WHERE created_at >= ?) — AC-1, AC-2 - Add GetSubcommandBreakdown aggregation query using ent GroupBy — AC-4 - Add ListRecentCommandsByProgram returning last N command previews — AC-5 - Add GetSubcommandTrend returning per-day counts — AC-6 - Add GetProgramAnalytics ConnectRPC method returning SubcommandBreakdown, ExampleCommands, RuleCoverage, DailyTrend — AC-7 Frontend (React/TypeScript): - New ProgramDetailPanel component with subcommand frequency table (count, %, decision breakdown), example commands, rule coverage summary, trend sparklines, and "Add rule →" links — AC-8 through AC-13 - New useProgramAnalytics hook with AbortController cleanup - ApprovalAnalyticsPanel: clicking program row opens inline detail panel - ApprovalRulesPanel: fix panel crush in flex container (flexShrink: 0), use window.location.search in useEffect for URL param pre-fill (avoids useSearchParams/Suspense issues in Next.js static export) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address copilot review comments on analytics drill-down - Fix 1: exclude NULL command_subcategory rows in GetSubcommandBreakdown to avoid sql.ScanSlice scan errors on nullable GROUP BY columns - Fix 2: replace strings.Fields tokenizer in coveredSubcommands() with regexp.Compile + synthetic "<program> <subcommand>" matching so regex-style patterns (e.g. \bgit\b.*\bpush\b) work correctly - Fix 3: add TestGetProgramAnalytics_ReturnsExpectedFields unit test covering window_days=7 and non-nil response fields - Fix 4: add escapeRegex() helper in ApprovalRulesPanel and use it when prefilling commandPattern to avoid metacharacter injection; switch word boundaries from \b to (?:^|\s)/(?:\s|$) for hyphenated program names - Fix 5: add e.stopPropagation() on Suggest Rule button and "add manually" link so clicking them does not toggle the parent <tr> drill-down row - Fix 6: add tabIndex, role=button, aria-expanded, aria-label, and onKeyDown (Enter/Space) to the clickable <tr> for keyboard accessibility - Fix 7: call setData(null) before setIsLoading(false) in error path of useProgramAnalytics to clear stale data on refresh failure - Fix 8: render per-program daily trend sparkline in ProgramDetailPanel; note that trend data is per-program not per-subcommand (backend limit) - Fix 9: thread caller context through LoadProgramWindow, GetSubcommandBreakdown, and ListRecentCommands instead of context.Background() * feat(rules): add criteria_programs/subcommands to custom rules, deprecate regex prefill Extend custom/runtime approval rules with structured CommandCriteria matching (Programs + Subcommands) as an alternative to regex command_pattern. - ent schema: add optional JSON fields criteria_programs and criteria_subcommands - proto ApprovalRuleProto: fields 15/16 for criteria_programs/subcommands - session/repository.go + ent_repository.go: thread new fields through domain model and DB upsert - rules_store.go: RuleSpec gains CriteriaPrograms/CriteriaSubcommands; specsToRules() populates rule.Criteria when programs are set; reload/upsert pass fields through - rules_service.go: specToProto/ruleToSpec/UpsertApprovalRule thread the new fields; coveredSubcommands() checks criteria-based rules directly without synthetic regex matching - ApprovalRulesPanel.tsx: RuleFormState gains criteriaPrograms/criteriaSubcommands; form inputs added with hint text; URL param pre-fill now populates criteria fields instead of commandPattern regex; match info column shows criteria chips - useApprovalRules.ts: passes criteriaPrograms/criteriaSubcommands to proto request Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fuse.js was running synchronously on every keystroke in the omnibar, causing a 931ms long task during typing. Three changes fix this: - Add 150ms debouncedInput in Omnibar — sessionSearchQuery, displayedSessionResults, and displayedRepoEntries all read from it instead of the raw input value, so Fuse only fires after typing pauses - Add selectActiveSessionsSortedByUpdatedAt (createSelector) to sessionsSlice, removing the inline .filter().sort() that ran on every omnibar render - Add browser profiling phase (Phase 5) to perf:make-it-faster command Update Omnibar.discovery test to assert debounced behaviour.
- Auto-trigger triage on item creation (R1); skip via skipTriage flag - Vagueness detection: prompt users to refine items with <80 char description and no AC before triage (R2) - TriageReviewPanel: diff view of current vs suggested AC, task checklist with estimates/categories, apply/skip/undo actions (R4, R5) - Apply triage suggestions: updates AC list and transitions item to "ready" in one action (R5) - INPUT_REQUIRED notification with deep-link when triage completes (R6) - Trigger Triage button for manual re-triage and error recovery - Fix backlog page infinite reload loop caused by unstable useBacklogService return object; add regression tests (T-STAB-001, T-STAB-002) - Double-trigger guard prevents duplicate triage sessions - Triage prompt instructs AI to return structured tasks[] array for implementation plan
Sessions spawned via the MCP create_session tool now always carry the source:mcp tag so they can be filtered distinctly in the session list.
… sessions Adds a complete session supervision system so automated sessions (backlog triage/work/review and MCP-created) run fully unattended: - Universal driver wiring: SessionDriver now runs for all automated session creation paths. MCP create_session gains the driver call; backlog sessions already flowed through CreateDirectorySession which was wired earlier. - Startup dialog handling: driver answers the Claude Code trust-folder safety check and directory-access dialogs on every poll tick before the initial prompt is sent. - Inactivity detection: after the initial prompt is sent, if the session stays in Ready state with no output change for 10 minutes it is considered stuck and restarted (driverTotalTimeout raised to 25 min as a safety net). - Exit detection: unexpected Stopped status after the initial prompt triggers a retry. One-shot sessions (backlog:triage, backlog:review) are skipped. Sessions that ran for > 5 minutes are treated as normal completions. - Auto-retry with JSONL continuation: on first failure the session is restarted with a prompt built from its JSONL conversation history (last 10 messages, last assistant turn truncated to 500 chars). On second failure the session is added to the ReviewQueue (ReasonStale) for human attention. - Idempotency guard: StartSessionDriver uses atomic.Bool.CompareAndSwap so a second call on the same instance is a no-op. - Panic recovery: defer/recover inside runSessionDriverWithPrompt protects both the initial and retry driver goroutines from crashing the server. Also fixes the omnibar path display: long paths now wrap instead of truncating.
…gger git-status bursts PerfFix-1: WorkspaceService.findInstance called LoadInstances() on every GetVCSStatus, GetWorkspaceInfo, GetWorkspace, and ListWorkspaceTargets RPC. LoadInstances() re-hydrates all sessions from disk via FromInstanceData→Instance.Start, spawning PTY processes and running `tmux ls` for each session — holding the global fork lock and causing ~41.7B cycles / 808 mutex events under profiling. Fix: add LiveInstanceFinder interface satisfied by SessionService, wire it in NewSessionService, and replace the single findInstance method with findInstanceFast (tries O(1) live-poller lookup first, falls back to LoadInstances only for new sessions not yet in the poller). SwitchWorkspace also migrated: SaveInstances accepts a single-element slice, so the full LoadInstances call for the list was unnecessary. PerfFix-2: ReviewQueuePoller.AddInstance now calls PrimeDirtyCacheJitter() on each new session. Sessions added in a burst (e.g. startup) previously had synchronized 15s dirty-cache TTLs, causing all git-status subprocesses to expire and launch simultaneously. Jitter spreads them uniformly across the window. PerfFix-3: forbidigo lint rule guards against future per-request LoadInstances calls with path exclusions for the known-good sites.
HistoryLinker.correlateSession had an early-return guard:
if inst.HasClaudeSession() { return }
This prevented UUID updates when a user ran /clear in Claude Code,
which closes the old JSONL and opens a new one with a different UUID.
On cold restore the instance would resume the pre-/clear conversation
(or fail with "No conversation found" → silent restart via
recoverFromStaleResume) instead of starting fresh as the user intended.
Fix: add force bool parameter to correlateSession.
- ScanAll() (triggered by fsnotify on JSONL creation and on startup)
calls correlateSession(inst, true) for ALL instances, including
already-linked ones, so UUID changes are detected and stored promptly.
- scanAllSessions() (5s polling loop) calls correlateSession(inst, false)
to preserve the existing performance optimization of skipping
already-linked sessions on every tick.
- Start() now calls ScanAll() instead of scanAllSessions() for the
initial startup scan, catching UUID changes that occurred while the
service was down.
Backoff is bypassed when force=true; it still applies to unlinked
sessions in polling mode.
…ervice - session/instance_claude.go: add stateMutex.RLock to HasClaudeSession and GetClaudeSession; add stateMutex.Lock to SetClaudeSession (data race fix) - session/history_linker.go: eliminate TOCTOU in ScanAll by holding a single write lock for both backoff clear and snapshot copy - session/history_linker_test.go: rewrite AlreadyLinked test to exercise correlateSession(force=false) skip path; add regression test for force=true UUID update after /clear (was BLOCKER gap) - session/git/worktree.go: export isDirtyCacheTTL → IsDirtyCacheTTL - session/git/worktree_git.go: update references to IsDirtyCacheTTL - session/git_worktree_manager.go: reference git.IsDirtyCacheTTL constant; add PrimeDirtyCacheJitter() to GitManager interface - server/services/workspace_service.go: correct O(1) → O(N) in LiveInstanceFinder godoc; remove blank line breaking GetWorkspace godoc - server/services/workspace_service_test.go: add stubLiveFinder and tests for fast-path hit and live-finder-nil fallback to storage - server/server.go: document known startup race in HistoryLinker.Start comment
Renames the PTY multiplexer binary and all references from claude-mux to ssq-mux for naming consistency. Includes code, comments, docs, config, installer scripts, and .goreleaser.yaml (also adds ssq-hooks binary entry).
Introduces WorkflowEngine interface to replace the inline validTransitions map in backlog.go, making transition policy explicit and testable. Adds BacklogStatusEvent as an append-only ent entity that records every status transition (from, to, triggered_by, created_at) with an index on (item_id, created_at) for efficient history queries. Also hardens Storage.AddInstance to distinguish constraint errors from other persistence failures on upsert.
Adds WriteToSession(session_id, input, press_enter) to SessionService. Intended for programmatic approval of hook prompts and ad-hoc terminal input from the backlog SessionMonitor panel. Returns immediately after queueing; does not wait for PTY output.
…ody parse Benchmarks: wrap all four baseline push steps in a 3-attempt retry loop (git pull --rebase --autostash && git push) so rapid consecutive pushes no longer cause a permanent rejected-push failure. Demo GIFs: add permissions: contents: write to the publish-demos job so github-actions[bot] can commit the recorded GIF files to main. Release Please: add commit-search-body: false to release-please-config.json so the conventional commit parser does not attempt to parse commit message bodies for breaking-change footers. Without this, commit bodies containing Go source code (e.g. make([]T, 0, n)) cause an unexpected-token parse error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…perf (#98) * fix(verify): resolve sdd:6-verify findings Go: - pruneRepoCache: implement LRU trim — after TTL eviction, sort remaining entries by accessedAtNs and delete coldest until count ≤ repoCacheMaxEntries. Previously the cap was advertised but not enforced (keys slice was dead code). - openRepoEntry: wrap PlainOpenWithOptions error with path context; re-check cache after pruning to eliminate redundant PlainOpen under contention. - findMergeBase: propagate non-ErrObjectNotFound CommitObject errors instead of silently continuing; skip only missing objects from shallow clones. TypeScript: - useSessionNotifications: extract approvalId before object literal, removing two non-null assertions on optional-chain result. - useSessionNotifications: move dedup map prune before lastShown read so the captured value reflects post-prune state. - useSessionNotifications.test: type makeEvent with TestNotificationEvent interface instead of any. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(vcs): move repo/diff caches onto GoGitVCSReader; release mutex before OS calls Move repoCache, repoCacheSize, and diffStatCache from package-level globals to GoGitVCSReader struct fields. GoGitVCSReader{} remains valid — sync.Map and int64 are zero-value safe. This isolates cache state per reader instance, preventing cross-test contamination when multiple GoGitVCSReader values exist in the same process (e.g. concurrent test runs or benchmarks). pruneRepoCache, openRepoEntry, and openWorktree are now methods on *GoGitVCSReader; all callers within the file use g. prefix. HasUncommitted: release the per-repo mutex before the working-tree stat loop and hasUntrackedFiles directory walk. These phases call only os.Lstat and os.ReadDir — no go-git access — so holding the packfile-reader mutex was blocking concurrent VCS operations on the same repo unnecessarily. Index entry fields are captured as a plain []trackedFile slice before the unlock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(insights): time range filter, session detail drawer, cost projections, perf R1 — Time range filter: preset buttons (Today/7d/30d/90d/All/Custom) + custom date picker persisted via URL search params; from/to wired through to GetInsightsSummary and WatchInsights RPCs. R2 — Per-session detail drawer: slide-over panel (createPortal) showing session metadata, tools breakdown, and skill activations; click any session row to open; Escape/backdrop closes. R3 — Cost projections: useProjectedCost computes projected monthly spend from daily buckets (requires ≥7 days of data); useBudgetThreshold persists a localStorage budget threshold with SSR hydration guard; warning banner + card styling when projected spend exceeds threshold. R4 — Skeleton loaders: InsightsDashboardSkeleton shown immediately on mount before first RPC response; chart dynamic() imports use Skeleton as loading placeholder; Suspense boundary added for useSearchParams. R5 — Virtual scrolling: TableVirtuoso (react-virtuoso) for >50 session rows; scroll position preserved across live updates. R6 — Smooth live updates: surgical per-session state patch on WatchInsights events; exponential backoff reconnect (1s→30s cap) replaces silent drop; chart data transforms wrapped in useMemo to prevent recharts re-renders. R7 — Session table search/filter: Fuse.js path search + model family dropdown + clear button; filter state preserved across live update cycles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(insights): address review comments — date tz, UTC month bucketing, TableVirtuoso cells, test hydration assertion - InsightsDashboard: serialize date to URL using local timezone (not UTC toISOString) - TimeRangeFilter: parse URL date params as local T00:00:00/T23:59:59 (not UTC midnight) - useProjectedCost: compare bucket dates using UTC methods to match server-side UTC midnight keys - SessionsTable: return cells (not <tr>) from TableVirtuoso itemContent; use components.TableRow for row-level props - useBudgetThreshold test: assert initial isHydrated is false (not just typeof boolean) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: add planning artifacts for insights enhancement * fix(insights): code quality, test coverage, and UX improvements Code quality: - Extract fmtCost/fmtTokens/fmtPct/fmtDate/shortId to insightsFormatters.ts; standardize fmtPct to toFixed(1) across all consumers - Name retry delay magic numbers: INITIAL_RETRY_DELAY_MS / MAX_RETRY_DELAY_MS - Log WatchInsights stream errors to console instead of silently swallowing Correctness: - Filter surgical stream update events against active from/to time range; sessions outside the current filter window no longer appear in live patches Tests (+4): - useProjectedCost: February non-leap (28 days), leap year (29 days), UTC month boundary exclusion - useBudgetThreshold: invalid localStorage value (non-numeric) returns null UX: - ProjectedCostCard: show inline error when budget input is ≤ 0 or NaN - TimeRangeFilter: show range-error message when from > to (custom range) - InsightsDashboard: map raw gRPC error codes to user-friendly messages - SessionDetailDrawer: add aria-describedby + srOnly description for a11y Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(insights): remove last duplicate fmtCost in ProjectedCostCard, import from insightsFormatters Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The release-please failure is caused by missing PR creation permission (GitHub Actions not permitted to create PRs), not commit body parsing. The parse errors in the logs are debug messages, not failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…isplayName React hooks must be called unconditionally. DailySpendChart, ModelBreakdownChart, and ModelOverTimeChart all called useMemo after an early return on empty data. Move the memo calls above the early return — they are cheap no-ops on empty arrays and the behaviour is identical. SessionsTable: add displayName to the React.forwardRef TableBody component passed to Virtuoso so the react/display-name lint rule is satisfied. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The react/display-name rule cannot infer a display name for React.forwardRef calls used as values in an object literal inside useMemo. Setting .displayName after the fact is not visible to the lint rule at that location. Using eslint-disable-next-line is the correct suppression for this inert pattern — Virtuoso uses this TableBody ref purely for scroll container sizing, not for React DevTools identification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…iewports The New Session Omnibar had no maxHeight and its body didn't scroll, so on short viewports (or with Advanced Options expanded) the footer's Create Session button was clipped off-screen and unreachable. Adopts the same capped-height flex-column + scrollable-body shell already used by ResumeSessionModal and WorkspaceSwitchModal: `.modal` gets maxHeight:80vh + flex column, `.body` gets overflowY:auto + flex:1 + minHeight:0. Adds a Playwright regression test for the reported bug (Create button reachable at 1024x700 with Advanced Options expanded). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPQZEESEEK54zgGpMzo8sv
Add overscrollBehavior:"contain" to Omnibar.css.ts's .body (caught by sdd:6-verify's idiom review) so hitting the scroll boundary inside the newly-scrollable field region doesn't chain into scrolling/gesturing the page behind the modal overlay. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPQZEESEEK54zgGpMzo8sv
Owner
Author
|
Closing as superseded: this branch's last known commit (4eca0ed) is already present on main, so this item's work has already shipped through another path. No further fix is needed here. |
Owner
Author
|
Reopening: this branch's fix commits (be46c20, ab75ccb — the Omnibar.css.ts maxHeight/flex-column/overflow changes) are NOT present on main. The auto-close reasoning cited commit 4eca0ed, which is only this branch's merge-base with main (i.e. main's tip at branch-creation time) — that's true of every branch and isn't evidence the actual fix landed elsewhere. Confirmed via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The New Session creation modal (the Omnibar /
OmnibarCreationPanel) had no heightcap and its body didn't scroll. On short viewports (or with Advanced Options
expanded) the modal grew past the bottom of the screen and the footer's Create
Session button became unreachable — no session could be created.
This brings
Omnibar.css.tsin line with the capped-height flex-column +scrollable-body shell already shipped in
ResumeSessionModal.css.tsandWorkspaceSwitchModal.css.ts.What Changed
web-app/src/components/sessions/Omnibar.css.ts:.modalgainsmaxHeight: "80vh",display: "flex",flexDirection: "column".bodygainsoverflowY: "auto",overscrollBehavior: "contain",flex: 1,minHeight: 0.overlayand all other exports are untouchedtests/e2e/omnibar-modal-scroll.spec.tsas a permanent Playwrightregression test for this bug (1024x700 viewport, Advanced Options expanded,
asserts the Create Session button stays enabled and in-viewport)
project_plans/omnibar-modal-scroll/(requirements, research, plan, validation, pre-mortem, architecture review,
adversarial review)
No
.tsxchanges — the footer is already a sibling of.bodyinside.modal,so no markup restructuring was needed.
Test plan
cd web-app && npx tsc --noEmitpasses for the changed filecd web-app && npm run lintpasses for the changed fileclean runs):
.modalcomputedmaxHeight=560px(80vh of 700px),display: flex,flexDirection: column; actual rendered height stayedbetween 410-539px, always ≤ 560px
natural content height (~818px), well under the 960px cap — no forced
stretch,
.overlayhas zero difftests/e2e/omnibar-modal-scroll.spec.tsis written andcommitted per the plan, but did not reliably pass end-to-end in the CI
sandbox used for this session. Root-caused to a pre-existing, unrelated
issue: the app's
Ctrl+Shift+Khandler inOmnibarContext.tsxintermittently opens the Omnibar in discovery mode instead of creation
mode, and the "Directory" radio button occasionally detaches/remounts
mid-click. This reproduces identically on the untouched, pre-existing
session-create-directory.spec.ts, under heavy sandbox load (loadaverage ~66 on a 24-core box, swap exhausted) — so it predates and is
independent of this change. Recommend filing as a separate follow-up bug;
not fixed here since it would require touching
Omnibar.tsx, out ofscope for this CSS-only fix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NPQZEESEEK54zgGpMzo8sv