Rename insertionDirection front/back to top/bottom and add axis aliases - #773
Merged
seveibar merged 1 commit intoAug 2, 2026
Merged
Conversation
addibble
force-pushed
the
feat/insertion-direction-canonical-axes
branch
2 times, most recently
from
August 2, 2026 19:39
859c7e7 to
d067cba
Compare
Follows the matching Circuit JSON change. The +/-Y values are renamed from
"from_front"/"from_back" to "from_top"/"from_bottom" so every name is read off
the footprint as drawn in the 2D PCB view, "from_below" (-Z) is added to pair
with "from_above" (+Z), and each direction gains an equivalent Cartesian
spelling ("from_y_pos", "from_x_neg", ...).
"from_front" and "from_back" remain accepted as deprecated spellings so
existing sources keep compiling.
FootprintInsertionDirection is now an alias of Circuit JSON's
InsertionDirectionInput so the two lists cannot drift apart; expectTypesMatch
fails the build if the local z.enum stops agreeing with it.
Every spelling is kept in the prop type rather than normalized here, because
FootprintProps is the type JSX authors write against; normalizing would make
the aliases impossible to write. Core normalizes to the six named values
before writing pcb_component.insertion_direction.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
addibble
force-pushed
the
feat/insertion-direction-canonical-axes
branch
from
August 2, 2026 20:16
d067cba to
e076e67
Compare
seveibar
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the matching Circuit JSON change. The +/-Y values are renamed from "from_front"/"from_back" to "from_top"/"from_bottom" so every name is read off the footprint as drawn in the 2D PCB view, "from_below" (-Z) is added to pair with "from_above" (+Z), and each direction gains an equivalent Cartesian spelling ("from_y+", "from_x-", ...).
FootprintInsertionDirection is now an alias of Circuit JSON's InsertionDirectionInput so the two lists cannot drift apart; expectTypesMatch fails the build if the local z.enum stops agreeing with it.
Both spellings are kept in the prop type rather than normalized here, because FootprintProps is the type JSX authors write against. Core normalizes to the six named values before writing pcb_component.insertion_direction.